Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shahzaib/WALL-756/allow idv for vanuatu jurisdiction on MT5 #8907

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 9:15am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8907](https://github.com/binary-com/deriv-app/pull/8907)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-kyc-756-integration-wi-a96d6c.binary.sx?qa_server=red.binaryws.com&app_id=32517
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-kyc-756-integration-wi-a96d6c.binary.sx
- **App ID**: `32517`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-kyc-756-integration-wi-a96d6c.binary.sx/

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Generating Lighthouse report...

matin-deriv
matin-deriv previously approved these changes Jul 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit ca31c81 into binary-com:master Jul 26, 2023
5 checks passed
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
…om#8907)

* chore: allow idv for vanuatu jurisdiction on MT5

* chore: update document status message in jurisdiction cards regarding idv

* refactor: shared util function to check idv supported resident

* refactor: util function to get supported verification service

* chore: added flag to check if idv is disallowed

* fix: failing test cases

* refactor: refactoring the condition for better readability and conciseness

* refactor: nullish coalescing operator

* refactor: updated type for authenticationStatusInfo util function

* chore: updated conditions regarding the vanuatu idv support in cfd

* chore: updated conditions regarding the vanuatu idv support in cfd

* chore: minor condition update

* chore: update poa condition to poi in card banner

* chore: resolve review comments

* chore: prevent idv for eu region selection

* refactor: condition to check verification status for maltainvest in cfd

* refactor: renamed status variable for better readability

* refactor: renamed status variable name

* chore: update jurisdiction content

* chore: update jurisdiction title indicator

* chore: update test case

* chore: update test case for format-response

* chore: update test case for cfd-poi

* chore: empty commit

* fix: 🐛 resolved incorrect section display (#5)

* fix: failing test cases

---------

Co-authored-by: Shahzaib <shahzaib@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants