Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shahzaib / KYC-93 / add issuing country to uploading files in manual verification #9035

Merged
merged 46 commits into from
Jul 26, 2023
Merged

shahzaib / KYC-93 / add issuing country to uploading files in manual verification #9035

merged 46 commits into from
Jul 26, 2023

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 5:51am

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #9035 (bb7bb78) into master (d5c38a0) will not change coverage.
Report is 125 commits behind head on master.
The diff coverage is n/a.

❗ Current head bb7bb78 differs from pull request most recent head 7044954. Consider uploading reports for the commit 7044954 to get more accurate results

@@          Coverage Diff           @@
##           master   #9035   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9035](https://github.com/binary-com/deriv-app/pull/9035)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-kyc-93add-a-poi-issuin-fec057.binary.sx?qa_server=red.binaryws.com&app_id=24257
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-kyc-93add-a-poi-issuin-fec057.binary.sx
- **App ID**: `24257`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-kyc-93add-a-poi-issuin-fec057.binary.sx/

@shahzaib-deriv shahzaib-deriv marked this pull request as ready for review June 20, 2023 07:37
matin-deriv
matin-deriv previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, better to get @amina-deriv opinion as well.

@coveralls
Copy link

coveralls commented Jul 5, 2023 •
edited
Loading

Coverage Status

coverage: 8.885% (+0.001%) from 8.884% when pulling 7044954 on shahzaib-deriv:KYC-93_Add-a-POI-issuing-document-country-in-the-manual-upload into 0553c82 on binary-com:master.

@shahzaib-deriv
Merge branch 'master' of https://github.com/shahzaib-deriv/deriv-app …
2d98767 
…into KYC-93_Add-a-POI-issuing-document-country-in-the-manual-upload
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit 1af1cc5 into binary-com:master Jul 26, 2023
5 checks passed
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
@shahzaib-deriv @likhith-deriv @matin-deriv
shahzaib / KYC-93 / add issuing country to uploading files in manual …
5946078 
…verification (binary-com#9035)

* chore: add issuing country to uploading file meta data

* chore: update binary-document-uploader package

* chore: add document issuing country in poa & poo document uploading

* chore: reverted the null check line change

* chore: add missing country_code upon retrying verification

* chore: issuing country is not required at the moment from poo & poa

* chore: empty commit

* chore: update import path to fix eslint error message

* ci: update package.json

* chore: revert files affected by formatting

---------

Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@hamza-deriv hamza-deriv hamza-deriv approved these changes

@matin-deriv matin-deriv matin-deriv left review comments

@amina-deriv amina-deriv amina-deriv left review comments

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

Assignees
No one assigned
Labels
Account Components Shared Trader
Projects
None yet
Milestone
No milestone
9 participants
@shahzaib-deriv @amina-deriv @coveralls @matin-deriv @likhith-deriv @suisin-deriv @yauheni-deriv @hamza-deriv @bahar-sadeghzadeh