Shafin/bot 368/feat draggable transaction modal #9137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #9137 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 117 117
Lines 3425 3425
Branches 893 893
======================================
Hits 2 2
Misses 3423 3423 |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-368feat-dragg-97a182.binary.sx/ |
…shafin/BOT-368/feat--draggable-transaction-modal
rupato-deriv
approved these changes
Jun 26, 2023
sandeep-deriv
previously approved these changes
Jul 3, 2023
vinu-deriv
previously approved these changes
Jul 4, 2023
shafin-deriv
dismissed stale reviews from vinu-deriv and sandeep-deriv
via
77c0f62
|
⏳ Generating Lighthouse report... |
sandeep-deriv
previously approved these changes
Aug 17, 2023
sandeep-deriv
previously approved these changes
Aug 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sandeep-deriv
approved these changes
Aug 22, 2023
|
✨ PR has been merged by Paimon the Release Bot |
mahdiyeh-deriv
pushed a commit
to mahdiyeh-deriv/deriv-app
that referenced
this pull request
Aug 30, 2023
* feat: transaction details modal * feat: complete test cases for TransactionDetails modal * chore: fix code smells * chore: fix code smells * chore: remove code smells * chore: redeploy * chore: move transaction details types to types folder * feat: add draggable modal component * chore: finish test cases for draggable component * chore: add header props to draggable * chore: show enrty and exit tick if available * fix: transaction scroll css issue fix * fix: update key with data for divider inside transaction details modal * fix: update buy price to have decimal value * fix: css issue on modal height and fixed decimal profit/loss * fix: fix style for modal getting cut * fix: modal css issue after build * fix: decrease the modal height for edge cutting issue * fix: test case * Merge branch 'master' into shafin/BOT-368/feat--draggable-transaction-modal * fix: not closing on responsive view issue * fix: test case * fix: reduce preview workspace control z-index
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
Sep 1, 2023
* feat: transaction details modal * feat: complete test cases for TransactionDetails modal * chore: fix code smells * chore: fix code smells * chore: remove code smells * chore: redeploy * chore: move transaction details types to types folder * feat: add draggable modal component * chore: finish test cases for draggable component * chore: add header props to draggable * chore: show enrty and exit tick if available * fix: transaction scroll css issue fix * fix: update key with data for divider inside transaction details modal * fix: update buy price to have decimal value * fix: css issue on modal height and fixed decimal profit/loss * fix: fix style for modal getting cut * fix: modal css issue after build * fix: decrease the modal height for edge cutting issue * fix: test case * Merge branch 'master' into shafin/BOT-368/feat--draggable-transaction-modal * fix: not closing on responsive view issue * fix: test case * fix: reduce preview workspace control z-index
ali-hosseini-deriv
added a commit
that referenced
this pull request
Sep 21, 2023
* fix: fixed minor code smells in bot-web-ui * fix: added types for gtm in TCoreStores * fix: removed unnnecessary comments * Farzin/WALL-1628/Side Note issue on staging environment (#9820) * fix(cashier): 🐛 fix * fix(cashier): 🐛 fix * fix(cashier): 🐛 fix * fix(cashier): 🐛 fix * fix(cashier): 🐛 fix * fix: don't show side note in FIAT withdrawal page --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> * farhan/feat: add useSettings hook to @deriv/api (#9805) * chore: added useSettings to @deriv/api * chore: combine get_settings with set_settings * refactor: change function name * chore: return all mutation data * chore: export hook * refactor: types and mutation function name * translations: 📚 sync translations with crowdin (#9836) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: add optional chaining to prevent error (#9838) * farzin/feat(wallets): 📦 add `@deriv/wallets` workspace (#9756) * fix(cashier): 🐛 fix unable to access CFD-DerivX transfer * feat(wallets): 📦 add `@deriv/wallets` workspace * fix(wallets): 💚 fix CI build * feat(api): ✨ share a single instance of `QueryClient` in `APIProvider` * Merge branch 'master' into farzin/next --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * farhan/WALL-1583/Add useLandingCompany hook to @deriv/api (#9785) * feat: added use-authorize hook taken from sergei pr Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: sorted imports for use-authorize Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: moved default empty string in use-authorize * chore: incorporated code reviews * chore: added useLandingCompany into api package * chore: added useSettings to @deriv/api * chore: get country_code from user settings instead of authorize * chore: combine get_settings with set_settings * fix: change request type for landing_company * chore: combine get_settings with set_settings * refactor: change function name * chore: add missing dependencies for useLandingCompany return data * chore: return all mutation data * chore: export hook * refactor: types and mutation function name * refactor: use-landing-company-hook * fix: remove dependency --------- Co-authored-by: adrienne-rio <adrienne@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * adrienne/feat: added use-get-status-account hook (#9808) * feat: added use-get-status-account hook * chore: updated comments * fix: make use-accounts-list dependent on use-get-account-status hook * chore: incorporated review changes * fix: fixed typescript issue in wallets * farzin/feat: add `useTradingAccountsList`, `useActiveTradingAccount`, and `useActiveAccount` hooks (#9824) * refactor(api): ♻️ clean-up * feat(api): ✨ add `useTradingAccountsList`, `useActiveTradingAccount`, and `useActiveAccount` hooks --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Shafin/bot 368/feat draggable transaction modal (#9137) * feat: transaction details modal * feat: complete test cases for TransactionDetails modal * chore: fix code smells * chore: fix code smells * chore: remove code smells * chore: redeploy * chore: move transaction details types to types folder * feat: add draggable modal component * chore: finish test cases for draggable component * chore: add header props to draggable * chore: show enrty and exit tick if available * fix: transaction scroll css issue fix * fix: update key with data for divider inside transaction details modal * fix: update buy price to have decimal value * fix: css issue on modal height and fixed decimal profit/loss * fix: fix style for modal getting cut * fix: modal css issue after build * fix: decrease the modal height for edge cutting issue * fix: test case * Merge branch 'master' into shafin/BOT-368/feat--draggable-transaction-modal * fix: not closing on responsive view issue * fix: test case * fix: reduce preview workspace control z-index * farabi/bot-385/embed hotjar attribution (#9419) * fix: added new attributes for hotjar * refactor: separated hotjar script to a function in utils * fix: updated attribute * fix: added optional for client login id * chore: added comment for attribution code * Arshad/ WALL-833/ show correct platform on trader's hub onboarding (#9680) * fix: show correct platform on trader's hub onboarding * test: ✅ added onboarding test for financial restricted countries * fix: fixed cfd restricted countries * chore: use sass instead of node-sass (#8916) * chore: use sass instead of node-sass * docs: remove node-sass from readme file * docs: fix typo in readme file * chore: retrigger ci tests * fix: ci test failed --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Kate / OPT-347 / Opening the Duration Tab for the first time will show incorrect expiry time (#9732) * chore: draft * feat: expant function and hardcoded date * refactor: add usage moment library * chore: remove extra space * likhith/fix: sending empty payload to non idv countries (#9739) * fix: sending empty payload to non idv countries * fix: sending empty payload to non idv countries * Farabi/bot 399/hide bot too risky modal (#9542) * fix: removed bot too risky modal and updated stop icon * fix: added toast notification when user stops bot * fix: fixed snack bar for quick strategy run * fix: added close function on snackbar * fix: added clear and reset timeout on hovering on toast * fix: added test case for bot-stop-notification * fix: stop bot snack bar appearing with no trade again * translations: 📚 sync translations with crowdin (#9856) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * FarhanNurzi/feat: WALL-1574/Add useAvailableAccounts hook to @deriv/api (#9786) * feat: added use-authorize hook taken from sergei pr Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: sorted imports for use-authorize Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: moved default empty string in use-authorize * chore: incorporated code reviews * chore: added useLandingCompany into api package * chore: added useLandingCompany into api package * chore: added useAvailableAccounts and useAccountTypes hooks into api package * chore: added useSettings to @deriv/api * chore: get country_code from user settings instead of authorize * chore: combine get_settings with set_settings * fix: change request type for landing_company * chore: combine get_settings with set_settings * refactor: change function name * chore: add landing_company field to each account types * chore: add missing dependencies for useLandingCompany return data * chore: return all mutation data * chore: export hook * refactor: types and mutation function name * refactor: use-landing-company-hook * fix: remove dependency * fix: remove dependency * refactor: use-available-accounts hook * fix: review comments, remove gaming accounts * refactor: separate accounts usememo --------- Co-authored-by: adrienne-rio <adrienne@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * thisyahlen/chore: add useTradingPlatformAvailableAccounts to deriv api (#9810) * chore: add useTradingPlatformAvailableAccounts to deriv api * fix: type repetition annd fallback * refactor: repetition * fix: empty commit * fix: empty commit * fix: comment * thisyahlen/feat: wallet-list-desktop (#9829) * fix(cashier): 🐛 fix unable to access CFD-DerivX transfer * feat(wallets): 📦 add `@deriv/wallets` workspace * fix(wallets): 💚 fix CI build * feat(api): ✨ share a single instance of `QueryClient` in `APIProvider` * Merge branch 'master' into farzin/next * chore: add wallet header list data for desktop --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * farhan/feat: Added Wallet Carousel to @deriv/wallets (#9847) * fix(cashier): 🐛 fix unable to access CFD-DerivX transfer * feat(wallets): 📦 add `@deriv/wallets` workspace * fix(wallets): 💚 fix CI build * feat(api): ✨ share a single instance of `QueryClient` in `APIProvider` * Merge branch 'master' into farzin/next * chore: created mobile wallets carousel Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * thisyahlen/chore: update wallet loginids (#9866) * farzin/refactor(api): ♻️ clean-up (#9864) Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * adrienne/feat: added svg bundling for wallets (#9871) * feat: added svg bundling for wallets * chore: removed assets folder in wallets * henry/webrel-1160/hotfix: space issue dropdown (#9898) * fix: space issue dropdown * fix: resolve comment * fix: comment * Update packages/components/src/components/dropdown/dropdown.scss * fix: empty commit --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * fix: overwritten styles (#9899) * fix: overwritten styles * fix: overwritten styles * Ameerul /WEBREL-1159 Sort by column alignment in P2P Buy/Sell page is off (#9876) * chore: fixed sort dropdown alignment * chore: changed styling for dropdown * george / PRODQA-1316 / Transfer from Tradershub validation (#9908) * fix: 🚑 fix active container for TH transfer, fix insufficient balance check * test: 🐛 fix tests * fix: 🚑 fix 'Insufficient balance' condition * translations: 📚 sync translations with crowdin (#9912) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#9917) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Hirad-Hamza-ShonTzu/Feature revamp compare account re-deployment (#9611) * feat: initializing the compare account implementation * feat: icon reusable component v1.0 * feat: icon reusable component v1.1 * feat: icon reusable component v1.1.1 * feat: initialize compare cfd account page (todo:css) * feat: blank compare cfd accounts page & navi done * feat: mobile view * fix: compare-accounts naming convention * fix: updated path import * fix: reverted icons.js changes * fix: compare-cfds -> compare-accounts * feat: reusable component v1.2 * feat: reusable component v1.2.1 * feat: icon reusable component added v1.3 * feat: reusable component for Icons * feat: reusable component for Icons refactor * feat: reusable component for Icons refactor v1.2 * feat: description div added * feat: description with title +icon is added * feat: platform label + icon component padding added * chore: labuan leverage updated * chore: css issue fixed for Cards * feat: carousel added with sorting o f MT5 accounts * feat: carousel arrow background and container added * chore: added dxtrade in the card for dynamic rendering with type fixes * chore: changes in platform label header with respect to props data * chore: icons updated because of white line issue in icons * chore: change the components css name and other naming convention tweaks * refactor: suggestions implemented * refactor: convert carousel button into one * feat: initial commit for starting collaboration * feat: added the button placeholder * feat: added new banner to cfd cards * refactor: make the banner smaller * fix: added condition to show banner for derivez and ctrader only * refactor: changed the types and applied suggestions * refactor: removed the invalide shortcode for dxtrade * refactor: round up patches based on reviews * fix: round up patch 2 based on review * Update packages/cfd/src/Containers/cfd-compare-accounts/cfd-compare-accounts.scss Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> * refactor: button width * refactor: button classname * chore: fix css of underline * chore: added redirection to homepage in case of modals * fix: circle ci failed due to wrong type of client function * chore: added the disabled property for the Added accounts * chore: added condition for the dxtrade * chore: rearrange block scoped variables * chore: fix css of labuan tooltip with removal of commented code * chore: responsive view fixes * feat: demo accounts added for low risk * feat: demo accounts label added and swap-free account creation fixed * chore: added derivx account creation flow * refactor: replace ternary operators with if-else * chore: remove unused jurisdiction * feat: demo account compare implemetation tweaks as per design * feat: rectified the Demo title as per design * chore: font weigth of instruments as per design * feat: Eu flow for DIEL * feat: changes in the icons label and correction in EU flow * chore: addded translations demo title and rename baskets * chore: rename icon type * chore: final changes prop drilling instead of observer EU flow finalized * fix: hidding deriv ez * fix: EU flow platform label change * feat: test case for description added * feat: platform label test case added * feat: title icon test case added * feat: title icon test case added * chore: fix test case description + instruments icon test added * refactor: blank spaces removed * chore: cfd-instruments-label test added * chore: test file added cfd-instrument-label * feat: button partial test case added * chore: added more test case for Button component * feat: added test case for compare-account-card * chore: merge conflicts * chore: test for cfd-compare-accounts added * feat: derivX demo * chore: added testcase for dxtrade in button * fix: dxtrade for australian clients * fix: swapfree account creation added * fix: comapre account fixes first round * fix: remove the css because scroll not working * fix: renamed variable + icons * fix: cursor not allowed on instrument icons * fix: fixed the circle ci issue * fix: fixed one of our test issues * refactor: review comments resolved * fix: changing the text of mf accounts to pass the tests * fix: made changes according to suggestions * fix: made changes according to suggestions * fix: fixed the test case issues * chore: added s to spread(s) * chore: fixed capitalization * chore: line split * fix: failing test case * fix: updated markets offerings for MT5 Financial Labuan * fix: Other CFDs --> Other CFDs Platform * fix: removed standard/micro from DerivX Forex label * refactor: optimised code * fix: icon size inconsistencyn mobile VP * refactor: css refactoring to reflect figma as much as possible * refactor: minor css fixes * fix: fixed * style: added bottom padding for mobile * fix: fixed the build issue * chore: re running the tests * fix: subtasks * chore: typo * style: position the tooltip to be center within the card * style: resize width for word-wrap * chore: d and r should be lowercase dispute and resolution * fix: fixing sonar cloud issues * fix: making changes to pass the tests --------- Co-authored-by: hamza-deriv <hamza.muhammad@regentmarkets.com> Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> * adrienne/chore: added eslint and stylelint for wallets and renamed css variables (#9877) * feat: added stylelint for wallets for bem convention * feat: added stylelint for wallets for bem convention * chore: added import sorts for wallets and bem convention checking * chore: removed unused dependencies in wallets * Arshad/Matin/WALL-1226/Dynamic leverage for MT5 financial accounts (#9314) * chore: Dynamic leverage for MT5 financial accounts initial commit * feat: 🚧 dynamic leverage modal * test: unit tests * feat: ✅ added unit tests and refactoring * feat: ♻️ fixed UI * feat: ♻️ review changes for dynamic leverage * chore: item name update * feat: 🐛 passed string to localize instead of a variable * test: ♻️ * refactor: ♻️ refactored column header to new component * refactor: refactored code * fix: fixed styling and refactored code * style: formatted code * test: updated test mock component * refactor: refactored styling and unit tests * fix: fixed text content for dynamic leverage * fix: fixed localize component usage * refactor: used strong instead of span styling * fix: jurisdiction card layout --------- Co-authored-by: arshad-rao-deriv <muhammad.arshad@deriv.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#9924) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#9925) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: removed unecessary comments * fix: removed unecessary comments * fix: removed unecessary comments got added by eslint * fix: removed unecessary comments got added by eslint * fix: remove comments added while commiting --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: adrienne-rio <adrienne@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: Arshad Rao <135801848+arshad-rao-deriv@users.noreply.github.com> Co-authored-by: Hamid <hamid@regentmarkets.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev> Co-authored-by: hamza-deriv <hamza.muhammad@regentmarkets.com> Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: arshad-rao-deriv <muhammad.arshad@deriv.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.