Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wallets Onboarding #9162

Conversation

aizad-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:03am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9162](https://github.com/binary-com/deriv-app/pull/9162)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-6onboarding-wallets.binary.sx?qa_server=red.binaryws.com&app_id=23824
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-6onboarding-wallets.binary.sx
- **App ID**: `23824`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-6onboarding-wallets.binary.sx/

@boring-cyborg boring-cyborg bot added the Core label Jun 30, 2023
…eriv/deriv-app into aizad/WALL-6/onboarding-wallets
@coveralls
Copy link

coveralls commented Jul 5, 2023

Coverage Status

coverage: 10.251% (-0.002%) from 10.253% when pulling 7d17e57 on aizad-deriv:aizad/WALL-6/onboarding-wallets into e9d9323 on binary-com:feature/wallets_with_traders_hub.

@nijil-deriv nijil-deriv changed the base branch from feature/wallets_with_traders_hub to feature/wallets_with_traders_hub_2 August 8, 2023 09:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@nijil-deriv nijil-deriv merged commit eb1f052 into binary-com:feature/wallets_with_traders_hub_2 Aug 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants