Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css for compare account af pakistan madagascar afghanistan #9204

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 6:58am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9204](https://github.com/binary-com/deriv-app/pull/9204)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-1234afpkmgcomparemo-0bfd9c.binary.sx?qa_server=red.binaryws.com&app_id=24060
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-1234afpkmgcomparemo-0bfd9c.binary.sx
- **App ID**: `24060`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-1234afpkmgcomparemo-0bfd9c.binary.sx/

@coveralls
Copy link

coveralls commented Jul 4, 2023

Coverage Status

coverage: 8.844%. remained the same when pulling e94cc4d on hamza-deriv:hamza/1234/af_pk_mg_compare_modal_css_broken into 7e05725 on binary-com:master.

mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Jul 4, 2023
hirad-deriv
hirad-deriv previously approved these changes Jul 4, 2023
@hirad-deriv hirad-deriv dismissed stale reviews from mahdiyeh-deriv and themself via a61f7e2 July 11, 2023 04:00
@matin-deriv
Copy link
Contributor

Since it is a temp solution until compare account project is ready on production then LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit cb28e54 into binary-com:master Jul 11, 2023
4 of 5 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants