Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niloofar | Mark | @deriv/integration and playwright implementations [POC] #9761

Merged
merged 19 commits into from
Sep 13, 2023
Merged

Niloofar | Mark | @deriv/integration and playwright implementations [POC] #9761

merged 19 commits into from
Sep 13, 2023

Conversation

niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented Aug 20, 2023 •
edited
Loading

This PR includes the following changes:

  • Added @deriv/integration package to the project for adding our mocked_data and general integration files! later we can move this package outside the deriv-app and use it where ever we want!
  • Added Playwright configuration in the root of the project! also for making sure that everything will working properly in the future I added this in the account and integration packages as well!
  • Since we no more need the end-to-end folder I removed that and added Mocked files from end-to-end folder to the @deriv/integration package from @markwylde-deriv 's PR

@vercel
Copy link

vercel bot commented Aug 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 10, 2023 8:37am

@boring-cyborg boring-cyborg bot added the Docs label Aug 20, 2023
@niloofar-deriv niloofar-deriv changed the title Niloofar/862k6k9q2/deriv test tool Niloofar Sadeghi / Add integration test configs Aug 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9761](https://github.com/binary-com/deriv-app/pull/9761)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-niloofar-862k6k9q2deri-7949e3.binary.sx?qa_server=red.binaryws.com&app_id=24056
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-niloofar-862k6k9q2deri-7949e3.binary.sx
- **App ID**: `24056`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-niloofar-862k6k9q2deri-7949e3.binary.sx/

@coveralls
Copy link

coveralls commented Aug 20, 2023 •
edited
Loading

Coverage Status

coverage: 10.235% (-0.001%) from 10.236% when pulling 5f4041a on niloofar-deriv:niloofar/862k6k9q2/deriv-test-tool into 98d25d5 on binary-com:master.

@niloofar-deriv niloofar-deriv changed the title Niloofar Sadeghi / Add integration test configs Niloofar Sadeghi / integration test configs Aug 20, 2023
@niloofar-deriv niloofar-deriv changed the title Niloofar Sadeghi / integration test configs Niloofar Sadeghi / Integration test configs Aug 20, 2023
@niloofar-deriv niloofar-deriv force-pushed the niloofar/862k6k9q2/deriv-test-tool branch from 3120051 to a449d46 Compare August 20, 2023 14:22
@niloofar-deriv niloofar-deriv force-pushed the niloofar/862k6k9q2/deriv-test-tool branch from 306a527 to b4613ed Compare August 23, 2023 11:39
@niloofar-deriv niloofar-deriv force-pushed the niloofar/862k6k9q2/deriv-test-tool branch from b4613ed to a7dc2d7 Compare August 27, 2023 10:03
markw-deriv
markw-deriv previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@markw-deriv markw-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd have a think about renaming all those e2e-test folders to something else, as they aren't really for e2e anymore.

packages/integration/src/utils/constants.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated
],

/* Run your local dev server before starting the tests */
// webServer: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the auto start stuff actually work? Can it ever work with our setup? If not, can we just delete these lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't setup this because we need to serve different packages for running the tests!
For example for your example test I need to serve core and appstore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove the extra commented configs

@markw-deriv markw-deriv mentioned this pull request Sep 4, 2023
Closed
markw-deriv
markw-deriv approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@markw-deriv markw-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since I worked on this POC let's get at least one other approver though :)

@niloofar-deriv niloofar-deriv changed the title Niloofar Sadeghi / @deriv/integration and playwright implementations Niloofar | Mark / @deriv/integration and playwright implementations [POC] Sep 4, 2023
@niloofar-deriv niloofar-deriv changed the title Niloofar | Mark / @deriv/integration and playwright implementations [POC] Niloofar / @deriv/integration and playwright implementations [POC] Sep 4, 2023
@niloofar-deriv niloofar-deriv changed the title Niloofar / @deriv/integration and playwright implementations [POC] Niloofar | Mark | @deriv/integration and playwright implementations [POC] Sep 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
54.9% 54.9% Duplication

@github-actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@markw-deriv markw-deriv merged commit 6596cca into binary-com:master Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv ali-hosseini-deriv approved these changes

@amina-deriv amina-deriv amina-deriv approved these changes

@markw-deriv markw-deriv markw-deriv approved these changes

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@shayan-deriv shayan-deriv Awaiting requested review from shayan-deriv

@farzin-deriv farzin-deriv Awaiting requested review from farzin-deriv

Assignees
No one assigned
Labels
Account AppStore Core Docs
Projects
None yet
Milestone
No milestone
8 participants
@niloofar-deriv @coveralls @farzin-deriv @yashim-deriv @ali-hosseini-deriv @amina-deriv @shayan-deriv @markw-deriv