noc/uninitialized_value_concatenation

[denissafiullin-deriv]

Currently $log->debug produces a warning due to the uninitialised value of $c->tx->remote_address. During the last month, there were 277 warn logs out of 1.04 million connections, which is 0.027 %. To solve the issue, the following steps were taken:

1. Use Log::Any instead of Mojo::Log to be able to use debugf instead of debug and to follow the Perl Style Guide.
2. Avoid string interpolation as discussed here
3. Use single quotes instead of double quotes, as interpolation is not required
4. Fallback to string undef if remote_address wasn't resolved.

ClickUp card: https://app.clickup.com/t/20696747/PLA-768

[review-deriv]

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

[review-deriv]

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

[mariovw-deriv]

can we use debugf here?

[denissafiullin-deriv]

Yes, replaced with debugf

[chylli-deriv]

log::any format log can handle undef

Suggested change

	$log->debug('accepting a websocket connection from ' . $remote_address);
	$log->debugf('accepting a websocket connection from %s', $c->tx->remote_address);

[denissafiullin-deriv]

Thank you. Introduced Log::Any

[aisha-deriv]

@denissafiullin-deriv please add changes file