Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium download link #51

Closed
fonghou opened this issue Nov 14, 2016 · 1 comment
Closed

Chromium download link #51

fonghou opened this issue Nov 14, 2016 · 1 comment
Labels

Comments

@fonghou
Copy link

fonghou commented Nov 14, 2016

Hi,

Chromium download link in the release note doesn't seems pointing to expected version, ~56.0.2918.2.

Here is the copied link for 0.8.4.

http://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/423378/chrome-mac.zip

However, I see "Version 55.0.2882.0 (64-bit)" in chrome://help.

Thanks!

@darwin
Copy link
Member

darwin commented Nov 15, 2016

You are right, it looks like I forgot to replace hard-coded version with $VERSION in the link here:

POSITION=`curl -s "https://omahaproxy.appspot.com/deps.json?version=55.0.2882.4"| python -mjson.tool | grep chromium_base_position | cut -d ":" -f 2 | sed "s/[ ,\"]//g"`

Will fix it tomorrow.

@darwin darwin added the bug label Nov 15, 2016
@darwin darwin closed this as completed in 3b2f46f Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants