Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to filter already-reviewed pull requests, regardless of approval status #259

Merged
merged 1 commit into from
May 2, 2019

Conversation

rgeraldporter
Copy link
Contributor

Since the GitHub API now gives you review status, I felt it was prudent to suggest this.

This helps cut down the list so that only PRs that have no reviews at all get listed, as a PR with zero feedback is the blocker I'm looking to address -- its merge status or approval is less urgent in my use case.

I figured this would be useful to others, feel free to make suggestions for changes, and thank you for this cool bot!

@rgeraldporter
Copy link
Contributor Author

Ref: #260

@binaryberry
Copy link
Owner

Hi @rgeraldporter - sorry I'd missed this. Happy to merge now, or unless you encountered any issues with it?

@rgeraldporter rgeraldporter reopened this May 2, 2019
@rgeraldporter
Copy link
Contributor Author

Thanks. I haven't encountered any issues myself, was just cleaning up my PRs.

@binaryberry
Copy link
Owner

Fab! Thanks for contributing, much appreciated!

@binaryberry binaryberry merged commit ae97f20 into binaryberry:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants