Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4: Replaced call to deprecated `with_scope' #358

Conversation

chrismaximin
Copy link
Contributor

As you can see in the official gem rails/activerecord-deprecated_finders, with_scope has been deprecated.

ActiveRecord::Base#with_scope and #with_exclusive_scope are deprecated.
Please use ActiveRecord::Relation#scoping instead. (You can use #merge to merge multiple scopes together.)

This update fixes that problem, by using 'where', 'merge' and 'scoping'.

@nathany
Copy link
Contributor

nathany commented Jun 14, 2013

Does it really take so much code to replace with_scope? :-(

@AKoetsier
Copy link
Contributor

Made the patch a little smaller and created a pull-request #369.

@binarylogic
Copy link
Owner

369 was merged in

@fguillen
Copy link

Can the fixed version be released? :)

@agirorn
Copy link

agirorn commented Feb 20, 2014

+1 for releasing the fixed version.

@mgiacomi
Copy link

I have a client bugging me about all the extra log messages. Any chance we can release this?

@nathany
Copy link
Contributor

nathany commented Feb 24, 2014

Please see #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants