Rails 4: Replaced call to deprecated `with_scope' #358

Closed
wants to merge 1 commit into
from

Projects

None yet

7 participants

Contributor

As you can see in the official gem rails/activerecord-deprecated_finders, with_scope has been deprecated.

ActiveRecord::Base#with_scope and #with_exclusive_scope are deprecated.
Please use ActiveRecord::Relation#scoping instead. (You can use #merge to merge multiple scopes together.)

This update fixes that problem, by using 'where', 'merge' and 'scoping'.

Contributor
nathany commented Jun 14, 2013

Does it really take so much code to replace with_scope? :-(

Contributor

Made the patch a little smaller and created a pull-request #369.

Owner

369 was merged in

Can the fixed version be released? :)

agirorn commented Feb 20, 2014

+1 for releasing the fixed version.

I have a client bugging me about all the extra log messages. Any chance we can release this?

Contributor
nathany commented Feb 24, 2014

Please see #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment