Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gemspec warnings & add missing 3.4.1 version #407

Merged
merged 1 commit into from
Apr 28, 2014

Conversation

tiegz
Copy link
Collaborator

@tiegz tiegz commented Apr 10, 2014

  • Update the gemspec version to 3.4.1 (which is the version listed on Rubygems right now)
  • Remove gem dependencies that are required by activerecord/activesupport anyway (cleans up gem build warnings)
  • Lockdown most of the dependencies from major-version upgrades (safer, and cleans up gem build warnings)

(Rails 4.1 was released this week too, so it was upgraded in Gemfile.lock, which we might want to ignore eventually anyway)

(3.4.1 is the version listed on rubygems.org, but it's not in the repo :\)
@tiegz tiegz mentioned this pull request Apr 11, 2014
binarylogic added a commit that referenced this pull request Apr 28, 2014
Cleanup gemspec warnings & add missing 3.4.1 version
@binarylogic binarylogic merged commit fca81f2 into binarylogic:master Apr 28, 2014
@tiegz
Copy link
Collaborator Author

tiegz commented Apr 28, 2014

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants