Extract rw_config into module, and clean it up a little. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private | ||
| # This is a one-liner method to write a config setting, read the config | ||
| # setting, and also set a default value for the setting. | ||
| def rw_config(key, value, default_value = nil) |
There was a problem hiding this comment.
didn't include the read_value arg because it didn't seem to be used.
tiegz
force-pushed
the
cleanup_rw_config
branch
from
908065d
to
e6dbad8
Compare
|
cc @binarylogic/authlogic-maintainers |
tiegz
force-pushed
the
cleanup_rw_config
branch
from
e6dbad8
to
d9c3749
Compare
| if value.nil? | ||
| acts_as_authentic_config.include?(key) ? acts_as_authentic_config[key] : default_value | ||
| else | ||
| self.acts_as_authentic_config = acts_as_authentic_config.merge(key => value) |
There was a problem hiding this comment.
the previous way of doing this (cloning the config) was a relic of Rails 3.1 compatibility, so that subclasses don't overwrite their parent class's config. We can achieve the same effect using merge.
tiegz
added a commit
that referenced
this pull request
Oct 9, 2014
Extract rw_config into module, and clean it up a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Move
rw_configinto a module, and include that module inAuthlogic::ActsAsAuthentic::BaseandAuthlogic::Session::Foundation. Tests included.WHY
Currently
rw_configis defined in the 2 modules, but their implementation is slightly different. We should make this easier to understand and test it.