Delete AuthlogicLoadedTooLateError #681
Conversation
This error no longer seems to be necessary. I tested this in a new rails 6.0.0 application. In the following, my debug output is prefixed with "->". ``` bin/rails server -> loading rails_adapter.rb => Booting Puma ... * Listening on tcp://localhost:3000 ... -> RailsImplementation included into ActionController::Base -> RailsImplementation included into ActionController::API -> loading application_controller.rb Started GET "/" for 127.0.0.1 at 2019-09-11 13:33:05 -0400 Processing by HomeController#index as HTML -> activate_authlogic Rendering home/index.html.erb within layouts/application ``` We can see that the `activate_authlogic` callback still occurs. So, raising an AuthlogicLoadedTooLateError would be incorrect. And, of course, I tested a normal sign in POST.
In #678, (released in 5.0.3) @hasghari switched us from an eager include to (LazyLoadHooks). Perhaps, now that we use |
There was a problem hiding this comment.
Yay for removing old code 🎊
@jaredbeck just to be safe, should we test this with Rails 5.2 as well? (I briefly tried to track down where ActionController filters changed but had no luck)
|
Thanks for the quick review, Tieg.
We test against rails 5.2 with CI. I don't have time for any additional manual testing today. Considering how broken 5.0.3 is, I'm feeling some pressure to get 5.0.4 out.
You were trying to determine why we needed |
|
Released as 5.0.4 |
This error no longer seems to be necessary.
I tested this in a new rails 6.0.0 application. In the following,
my debug output is prefixed with "->".
We can see that the
activate_authlogiccallback still occurs. So,raising an AuthlogicLoadedTooLateError would be incorrect.
And, of course, I tested a normal sign in POST.