New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order helper doesn't work with symbols in case of ascend_scope/descend_scope #115

Open

tanelj opened this issue Sep 15, 2010 · 0 comments

tanelj commented Sep 15, 2010

Order helper doesn't work with symbols in case of ascend_scope/descend_scope. User can't sort descending.

Does not work:
<%= order @search, :ascend_scope => :sort_by_report_total_amount_asc, :descend_scope => :sort_by_report_total_amount_desc %>

Works:
<%= order @search, :ascend_scope => 'sort_by_report_total_amount_asc', :descend_scope => 'sort_by_report_total_amount_desc' %>

It seems like line in rails.helper.rb
Line 30: ascending = search.order.to_s == options[:ascend_scope]

Should be:
Line 30: ascending = search.order.to_s == options[:ascend_scope].to_s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment