Properly implement to_hash #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
There is also another pull request also for |
Closed
|
cool! clear implementation :) |
|
👍 |
|
But still not pulled... |
|
Can this please be merged already? I believe my pull request is clean, well tested and fixes a weird oddity. Seems pretty straight forward to me. Thanks! |
|
The members of the organization seem not quite active... |
|
umm, what's going on. something problem? or what? please comment here... |
binarylogic
added a commit
that referenced
this pull request
Dec 30, 2012
Properly implement to_hash
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, calling to_hash always returned a SettingsLogic instance, which caused problems when calling methods such as #symbolize_keys on the resulting object.