Properly implement to_hash #44

Merged
merged 1 commit into from Dec 30, 2012

Conversation

Projects
None yet
5 participants
Contributor

cmer commented Oct 31, 2012

Without this, calling to_hash always returned a SettingsLogic instance, which caused problems when calling methods such as #symbolize_keys on the resulting object.

👍

There is also another pull request also for #to_hash: #25
Take a look

PikachuEXE referenced this pull request Nov 16, 2012

Closed

Implement #to_hash #25

cool! clear implementation :)

👍

But still not pulled...

Contributor

cmer commented Dec 28, 2012

Can this please be merged already? I believe my pull request is clean, well tested and fixes a weird oddity. Seems pretty straight forward to me. Thanks!

The members of the organization seem not quite active...
At least on this project

umm, what's going on.
the last pull request merged is 2 months ago, so this request may be already seen by authers.
6be535a

something problem? or what? please comment here...

@binarylogic binarylogic added a commit that referenced this pull request Dec 30, 2012

@binarylogic binarylogic Merge pull request #44 from cmer/master
Properly implement to_hash
a905605

@binarylogic binarylogic merged commit a905605 into binarylogic:master Dec 30, 2012

Contributor

cmer commented Dec 31, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment