Merge FBSSDC repo into binjs-ref #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on de31ebaa862ef351a3fcfa93859553808c7cc4b4 from a private, prototype repository.
The existing names suggest the work list is a queue, but in fact it is a stack. Rename things to reflect that. Closes binast#3.
Extending recursion limit
Rename ModelExplorer members to reflect work is in a stack.
RReverser
reviewed
Jun 25, 2019
fbssdc/.travis.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved | |||
|
|
|||
| language: python | |||
There was a problem hiding this comment.
I suppose this file will have to be modified somehow or manually called from top-level .travis.yml?
There was a problem hiding this comment.
Yes I will figure out how to get the Travis files to play together
There was a problem hiding this comment.
It would be nice to get this done before the merge.
| @@ -0,0 +1,54 @@ | |||
| # Contributing to FBSSDC | |||
There was a problem hiding this comment.
Is this and other similar files necessary given that it's now just a folder and not a separate repo?
There was a problem hiding this comment.
It's not necessary, I'll remove such files after the merge
|
Did you update this, @vdjeric ? |
|
Combined .travis.yml's |
|
Let's land it? |
Yoric
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that FBSSDC commit history is preserved and visible via "git log --follow"
I'll do follow-up commits to integrate Travis and other niceties
@Yoric @dominiccooney