Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sns, kms, multi-rds, multi-events #2

Merged
merged 1 commit into from
Oct 30, 2021
Merged

added sns, kms, multi-rds, multi-events #2

merged 1 commit into from
Oct 30, 2021

Conversation

vmalinics0
Copy link
Contributor

@vmalinics0 vmalinics0 commented Oct 29, 2021 •
edited

  • minor fixes
  • CMK KMS is optional, controlled by 'create_customer_kms_key' variable or 'customer_kms_key_arn' is used
  • Monitor SN is optional, contoller by 'create_notifications_topic' or 'notifications_topic_arn' is used
  • added S3 prefix for exports
  • multi-events can be defined in 'rds_event_ids'
  • multi-DBs are supported with 'database_names'
  • removed duplicating S3 name/arn
  • 'prefix' is optional now
  • updated example
  • added S3 prefix func
  • refactored functions to support changes
  • updated policies to support changes

@exequielrafaela exequielrafaela requested review from a team October 29, 2021 19:02
@vmalinics0
Copy link
Contributor Author

ah, forgot to mention, added S3 prefix as in 'snapshots_bucket_prefix'

@exequielrafaela exequielrafaela added this to the 2021 Q4 milestone Oct 30, 2021
@exequielrafaela exequielrafaela merged commit 598a109 into binbashar:master Oct 30, 2021
@exequielrafaela
Copy link
Member

@vmalinics0 thanks for your contribution, PR merged + release tagged and published => https://github.com/binbashar/terraform-aws-rds-export-to-s3/releases/tag/v0.2.0

CC: @binbashar/leverage-ref-architecture-aws-dev @binbashar/leverage-ref-architecture-aws-admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exequielrafaela exequielrafaela exequielrafaela approved these changes

@diego-ojeda-binbash diego-ojeda-binbash diego-ojeda-binbash approved these changes

Assignees

@diego-ojeda-binbash diego-ojeda-binbash

Labels
enhancement New feature or request feature patch
Projects
None yet
Milestone
2021 Q4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmalinics0 @exequielrafaela @diego-ojeda-binbash