fix(command): Do not run with -it if not on a TTY #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 373 377 +4
=====================================
+ Hits 373 377 +4
Continue to review full report at Codecov.
|
|
|
|
Tested on AWS CodeBuild and lookin' sexy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TTY is not provided on some CI test runners (notably, AWS CodeBuild), and results in Binci failing to run with the message
the input device is not a TTY. This change only connects the TTY if stdout itself is a TTY.(Note: still testing this change)