New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoding malformed Vec<> can cause unrecoverable OOMs irregardless of SizeLimit #41
Comments
After starting to use this more extensively, I've come to believe that the check I implimented here is flawed: If we're decoding a Also, these checks aren't on the encode size, meaning that I don't see the same bounds failures when encoding (which is a bit annoying). Anyhow: I'm not sure there is a way for us to grab the size_of the actual type we care about, and these checks won't actually help us if the size of the contained type is larger than the size of the container. |
Oh dang. Yeah, that's an issue. I think this could be solved by doing the check inside of the first
This is honestly the worst part for me. I also don't think that it is possible to do because we don't get the In the mean time, I'll revert those commits and try to think of a better way to write this. |
Example:
Output:
gdb backtrace:
The text was updated successfully, but these errors were encountered: