Impl BorrowDecode for Option<&[u8]> and Option<&str> #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes a lot of sense, we're only implementing Clippy has some new warnings, they will be fixed in #447. After that is merged can you rebase? PR looks good to me |
VictorKoenders
approved these changes
Dec 10, 2021
VictorKoenders
added a commit
that referenced
this pull request
Dec 11, 2021
VictorKoenders
added a commit
that referenced
this pull request
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since those two types are encodable, implements
BorrowDecodefor them is nature.