Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error in bincode derive where it would implement the wrong trait if a generic parameter is present #487

Merged
merged 5 commits into from
Jan 23, 2022

Conversation

VictorKoenders
Copy link
Contributor

@VictorKoenders VictorKoenders commented Jan 22, 2022

For any enum with generic argument T, bincode-derive would implement a code like:

impl<T> bincode::Decode for ... where T: bincode::enc::Decode {

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #487 (30423dd) into trunk (919ac4f) will increase coverage by 0.53%.
The diff coverage is 98.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #487      +/-   ##
==========================================
+ Coverage   68.73%   69.26%   +0.53%     
==========================================
  Files          39       39              
  Lines        2875     2925      +50     
==========================================
+ Hits         1976     2026      +50     
  Misses        899      899              
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
tests/alloc.rs 98.38% <ø> (ø)
tests/std.rs 100.00% <ø> (ø)
tests/utils.rs 31.81% <ø> (ø)
tests/derive.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919ac4f...30423dd. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 5c8a930 into trunk Jan 23, 2022
@VictorKoenders VictorKoenders deleted the derive-fix branch January 23, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants