Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the compatibility check also include bincode 2 serde, and added comments #501

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

VictorKoenders
Copy link
Contributor

Some of the code was redundant because we confirmed that the bincode_1_output was identical to the bincode_2_output. Therefor deserializing the same slice twice won't give different results.

Added a validation that bincode_2::serde also (de)serializes the same.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #501 (dc1efac) into trunk (8c0b68b) will increase coverage by 0.72%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #501      +/-   ##
==========================================
+ Coverage   68.35%   69.07%   +0.72%     
==========================================
  Files          43       43              
  Lines        3049     3056       +7     
==========================================
+ Hits         2084     2111      +27     
+ Misses        965      945      -20     
Impacted Files Coverage Δ
compatibility/src/lib.rs 50.90% <85.71%> (ø)
src/features/serde/ser.rs 33.96% <0.00%> (+9.92%) ⬆️
src/features/serde/de_owned.rs 42.45% <0.00%> (+13.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0b68b...dc1efac. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 6c7be9c into trunk Feb 6, 2022
@VictorKoenders VictorKoenders deleted the improved-compatibility branch February 6, 2022 08:50
ppamorim pushed a commit to ppamorim/bincode that referenced this pull request Feb 6, 2022
…comments (bincode-org#501)

* Made the compatibility check also include bincode 2 serde, and added comments

* Added a CI step to run the compatibility tests
ppamorim pushed a commit to ppamorim/bincode that referenced this pull request Feb 6, 2022
…comments (bincode-org#501)

* Made the compatibility check also include bincode 2 serde, and added comments

* Added a CI step to run the compatibility tests
ppamorim pushed a commit to ppamorim/bincode that referenced this pull request Feb 6, 2022
…comments (bincode-org#501)

* Made the compatibility check also include bincode 2 serde, and added comments

* Added a CI step to run the compatibility tests
ppamorim pushed a commit to ppamorim/bincode that referenced this pull request Feb 6, 2022
…comments (bincode-org#501)

* Made the compatibility check also include bincode 2 serde, and added comments

* Added a CI step to run the compatibility tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants