Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made config::standard() implement .write_fixed_array_header() by default #509

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

VictorKoenders
Copy link
Contributor

This will help with confusion when people are using bincode::serde:: as bincode::config::standard() won't give a runtime error.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #509 (692ed1b) into trunk (21eebcb) will increase coverage by 0.12%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #509      +/-   ##
==========================================
+ Coverage   70.77%   70.90%   +0.12%     
==========================================
  Files          47       47              
  Lines        3169     3159      -10     
==========================================
- Hits         2243     2240       -3     
+ Misses        926      919       -7     
Impacted Files Coverage Δ
src/config.rs 90.47% <ø> (ø)
tests/utils.rs 39.18% <0.00%> (+2.00%) ⬆️
tests/serde.rs 97.95% <90.90%> (+1.53%) ⬆️
tests/basic_types.rs 99.33% <100.00%> (+<0.01%) ⬆️
tests/issues/issue_474.rs 96.42% <100.00%> (ø)
src/de/impls.rs 78.39% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21eebcb...692ed1b. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 108e03b into trunk Feb 28, 2022
@VictorKoenders VictorKoenders deleted the feature/write_fixed_array_header_standard branch February 28, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants