Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple struct encoding in serde #549

Merged
merged 1 commit into from Jun 4, 2022
Merged

Fix tuple struct encoding in serde #549

merged 1 commit into from Jun 4, 2022

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jun 4, 2022

Closes #547

@ZoeyR ZoeyR requested a review from VictorKoenders June 4, 2022 12:37
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #549 (0a9ca59) into trunk (6ec69a3) will increase coverage by 0.44%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##            trunk     #549      +/-   ##
==========================================
+ Coverage   54.89%   55.33%   +0.44%     
==========================================
  Files          47       48       +1     
  Lines        4201     4223      +22     
==========================================
+ Hits         2306     2337      +31     
+ Misses       1895     1886       -9     
Impacted Files Coverage Δ
src/features/serde/ser.rs 74.19% <ø> (+5.08%) ⬆️
tests/utils.rs 44.70% <81.25%> (+5.51%) ⬆️
compatibility/src/misc.rs 100.00% <100.00%> (ø)
tests/issues/issue_547.rs 100.00% <100.00%> (ø)
tests/serde.rs 98.07% <100.00%> (+0.11%) ⬆️
src/lib.rs 13.71% <0.00%> (-0.02%) ⬇️
src/features/serde/de_owned.rs 74.61% <0.00%> (+1.74%) ⬆️
src/features/serde/mod.rs 52.38% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec69a3...0a9ca59. Read the comment docs.

@ZoeyR ZoeyR merged commit 5b19220 into trunk Jun 4, 2022
@VictorKoenders VictorKoenders deleted the serde-tuple-struct branch August 18, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glam crate is giving corrupt number when serialized via serde
2 participants