Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clippy warning and updated DecodeError #574

Merged
merged 1 commit into from Aug 18, 2022

Conversation

VictorKoenders
Copy link
Contributor

  • Fixed the clippy Eq warning.
  • Added DecodeError::Io (We were dropping the IO error before)
  • Removed PartialEq on DecodeError

Added DecodeError::Io
Removed `PartialEq` on DecodeError
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #574 (dd770c5) into trunk (3a4f299) will increase coverage by 1.38%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##            trunk     #574      +/-   ##
==========================================
+ Coverage   54.58%   55.97%   +1.38%     
==========================================
  Files          50       50              
  Lines        4437     4279     -158     
==========================================
- Hits         2422     2395      -27     
+ Misses       2015     1884     -131     
Impacted Files Coverage Δ
compatibility/src/membership.rs 100.00% <ø> (ø)
compatibility/src/rand.rs 100.00% <ø> (ø)
compatibility/src/sway.rs 100.00% <ø> (ø)
src/error.rs 0.00% <ø> (ø)
src/features/serde/mod.rs 47.82% <ø> (ø)
tests/issues/issue_474.rs 96.42% <ø> (ø)
tests/issues/issue_500.rs 100.00% <ø> (ø)
tests/serde.rs 98.07% <ø> (ø)
src/features/impl_std.rs 66.34% <28.57%> (ø)
tests/basic_types.rs 98.00% <33.33%> (-1.34%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VictorKoenders VictorKoenders mentioned this pull request Aug 17, 2022
@VictorKoenders VictorKoenders merged commit afa8ad4 into trunk Aug 18, 2022
@VictorKoenders VictorKoenders deleted the vko/fix_clippy_and_error_impls branch August 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants