Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincrafters-remove-outdated: suggest and/or track upstream issue to make tool obsolete #1320

Closed
Croydon opened this issue Dec 13, 2020 · 7 comments

Comments

@Croydon
Copy link
Member

Croydon commented Dec 13, 2020

I believe that the tool bincrafters-remove-outdated shouldn't be necessary to begin with.

Removing outdated binary packages from a remote should be something which is easily doable with official Conan capabilities

See also

@ericLemanissier
Copy link
Contributor

In theory it could be already replaced with a single call to conan remove -r REMOTE -o -f */* no ?

@Croydon
Copy link
Member Author

Croydon commented Dec 14, 2020

According to the documentation

https://docs.conan.io/en/latest/reference/commands/misc/remove.html

-o, --outdated Remove only outdated from recipe packages. This flag
can only be used with a reference

So almost, I think. We still need to get a list of all references.

I'm wondering if it would be reasonable to suggest advancing it for an entire remote and/or pattern?

WDYT? // @uilianries

@ericLemanissier
Copy link
Contributor

CONAN_REQUEST_TIMEOUT=3600 conan remove -r bincrafters -o -f "*/*" seems to work on my machine

@Croydon
Copy link
Member Author

Croydon commented Dec 14, 2020

This seems to work indeed! 🥳

Looks like you know more than the documentation 😄

Croydon added a commit to bincrafters/bincrafters-conventions that referenced this issue Dec 14, 2020
@Croydon
Copy link
Member Author

Croydon commented Dec 15, 2020

At least it work for me locally. CI runs for the maximum time and then times out

https://github.com/bincrafters/bincrafters-conventions/runs/1555012641?check_suite_focus=true

@ericLemanissier
Copy link
Contributor

That's surprising, it means the search for "/" failed 4 times with a timeout happening after 1h ?

@Croydon
Copy link
Member Author

Croydon commented Jan 17, 2021

This works fine now: https://github.com/bincrafters/bincrafters-conventions/blob/0ec9c9f5052a00bbcdb962d8dae0117b131ac323/.github/workflows/remove-obsolete-packages.yml#L27

Deprecating our own tool for the call conan remove -r <remote> --outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants