Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Fix msvc and xcode generators #3

Closed
wants to merge 1 commit into from

Conversation

uilianries
Copy link
Member

  • Update some points to work with python3 on Windows and OSX

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested a review from SSE4 November 20, 2018 14:50
Copy link
Member

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to make required changes into our fork https://github.com/bincrafters/gyp

@uilianries
Copy link
Member Author

@SSE4 should we create a new tag ?

@SSE4
Copy link
Member

SSE4 commented Nov 20, 2018

@uilianries yes, it would be nice

@uilianries
Copy link
Member Author

uilianries commented Nov 20, 2018

now we have two options,

remove all branches related to 20171101 and distribute only 20181120

or, add an error condition to 20171101 for msvc and osx

WDYT @SSE4 ?

@SSE4
Copy link
Member

SSE4 commented Nov 20, 2018

@uilianries just remove old, I don't think they are very frequently used

@uilianries
Copy link
Member Author

@SSE4 this will require removing the package as well

@SSE4
Copy link
Member

SSE4 commented Nov 20, 2018

I don't think it's a problem
also, we need to create latest alias (like for msys2_installer)
AFAIK the only project using it is https://github.com/bincrafters/conan-libuv, which has to be updated

@uilianries
Copy link
Member Author

@SSE4 nice, I'm gonna remove it

@uilianries uilianries closed this Nov 20, 2018
@uilianries uilianries deleted the testing/20171101 branch November 20, 2018 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants