Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button tap doesn't bounce back its state #18

Open
bozzmob opened this issue Dec 3, 2015 · 4 comments
Open

Button tap doesn't bounce back its state #18

bozzmob opened this issue Dec 3, 2015 · 4 comments

Comments

@bozzmob
Copy link

bozzmob commented Dec 3, 2015

Let me explain this behaviour. This is in reference to #9 and #10. But, clearly this issue is with the button component.
When I click on the button, it doesn't bounce back to released state. It is stuck in pressed state.

Phone - Samsung Galaxy S4
OS version - 5.0.1 and 5.1.1 (Tested on both)

I will look into this as well, will pull a PR soon. Just wrote it here so as to keep track of things.

@Ehesp
Copy link
Contributor

Ehesp commented Dec 5, 2015

Are you sure it's the button? If you go to the demo, with checkbox and hold down on the "box" item, the background effect is there... so it looks like it's more the ripple?

image

@bozzmob
Copy link
Author

bozzmob commented Dec 6, 2015

@Ehesp Yes, I am talking about the button. The same issue is there on buttons as well.

@Ehesp
Copy link
Contributor

Ehesp commented Dec 7, 2015

I think I found out why this happens, if you hold down the item, then scroll your view, let go the "touch up" trigger seems like it's not being triggered.

@Ehesp
Copy link
Contributor

Ehesp commented Dec 7, 2015

Hmm saying that, it doesn't happen on the latest demo APK for me... Unless something has changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants