Skip to content

Commit

Permalink
disable compiler override, enable cmake's detection
Browse files Browse the repository at this point in the history
  • Loading branch information
bingmann committed Jul 3, 2016
1 parent 556cc14 commit e0ec7de
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions android.toolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -1124,8 +1124,6 @@ if( APPLE )
endif()

# Force set compilers because standard identification works badly for us
include( CMakeForceCompiler )
CMAKE_FORCE_C_COMPILER( "${CMAKE_C_COMPILER}" GNU )
if( ANDROID_COMPILER_IS_CLANG )
set( CMAKE_C_COMPILER_ID Clang )
endif()
Expand All @@ -1137,7 +1135,6 @@ else()
endif()
set( CMAKE_C_HAS_ISYSROOT 1 )
set( CMAKE_C_COMPILER_ABI ELF )
CMAKE_FORCE_CXX_COMPILER( "${CMAKE_CXX_COMPILER}" GNU )
if( ANDROID_COMPILER_IS_CLANG )
set( CMAKE_CXX_COMPILER_ID Clang)
endif()
Expand Down Expand Up @@ -1618,8 +1615,6 @@ if( CMAKE_GENERATOR MATCHES "Ninja" AND CMAKE_HOST_WIN32 )
# CMake generates Ninja makefiles with UNIX paths only if it thinks that we are going to build with MinGW
set( CMAKE_COMPILER_IS_MINGW TRUE ) # tell CMake that we are MinGW
set( CMAKE_CROSSCOMPILING TRUE ) # stop recursion
enable_language( C )
enable_language( CXX )
# unset( CMAKE_COMPILER_IS_MINGW ) # can't unset because CMake does not convert back-slashes in response files without it
unset( MINGW )
endif()
Expand Down

2 comments on commit e0ec7de

@misery
Copy link

@misery misery commented on e0ec7de Jul 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a pull request to fix taka-no-me#71?

@bingmann
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure how this works. I copied it from some other commit in the fork tree, because it didn't work for me.
And one would have to support older cmake versions as well.

Please sign in to comment.