failed to apply Devel::PatchPerl 1.94 on old perls

[skaji]

Here are what I did.

❯ perl -MDevel::PatchPerl\ 999999
Devel::PatchPerl version 999999 required--this is only version 1.94.
BEGIN failed--compilation aborted.

❯ wget -q https://www.cpan.org/src/5.0/perl-5.8.1.tar.gz
❯ tar xf perl-5.8.1.tar.gz
❯ cd perl-5.8.1

❯ patchperl
Auto-guessed '5.8.1'
patching Configure
patching ext/Errno/Errno_pm.PL
patching Configure
patching utils/h2ph.PL
patching pp.c
patching Configure
2 out of 6 hunks FAILED -- saving rejects to file Configure.rej
Died at /Users/skaji/env/plenv/versions/relocatable-5.30.2.0/lib/site_perl/5.30.2/Devel/PatchPerl.pm line 443.

❯ echo $?
25

❯ cat Configure.rej
***************
*** 4646,4658 ****
  case "$hint" in
  default|recommended)
  	case "$gccversion" in
- 	1*) dflt="$dflt -fpcc-struct-return" ;;
  	esac
  	case "$optimize:$DEBUGGING" in
  	*-g*:old) dflt="$dflt -DDEBUGGING";;
  	esac
  	case "$gccversion" in
- 	2*) if $test -d /etc/conf/kconfig.d &&
  			$contains _POSIX_VERSION $usrinc/sys/unistd.h >/dev/null 2>&1
  		then
  			# Interactive Systems (ISC) POSIX mode.
--- 4646,4658 ----
  case "$hint" in
  default|recommended)
  	case "$gccversion" in
+ 	1.*) dflt="$dflt -fpcc-struct-return" ;;
  	esac
  	case "$optimize:$DEBUGGING" in
  	*-g*:old) dflt="$dflt -DDEBUGGING";;
  	esac
  	case "$gccversion" in
+ 	2.*) if $test -d /etc/conf/kconfig.d &&
  			$contains _POSIX_VERSION $usrinc/sys/unistd.h >/dev/null 2>&1
  		then
  			# Interactive Systems (ISC) POSIX mode.
***************
*** 22446,22452 ****

  : add -D_FORTIFY_SOURCE if feasible and not already there
  case "$gccversion" in
- [456789].*)	case "$optimize$ccflags" in
  	*-O*)	case "$ccflags$cppsymbols" in
  		*_FORTIFY_SOURCE=*) # Don't add it again.
  			echo "You seem to have -D_FORTIFY_SOURCE already, not adding it." >&4
--- 22446,22452 ----

  : add -D_FORTIFY_SOURCE if feasible and not already there
  case "$gccversion" in
+ [456789].*|[1-9][0-9]*)	case "$optimize$ccflags" in
  	*-O*)	case "$ccflags$cppsymbols" in
  		*_FORTIFY_SOURCE=*) # Don't add it again.
  			echo "You seem to have -D_FORTIFY_SOURCE already, not adding it." >&4

devel-patchperl/lib/Devel/PatchPerl.pm

Lines 10053 to 10054 in 14c825f

	return unless $num < 5.031006;
	return if $num >= 5.030002;

Could you make sure these version checks are correct?

[bingos]

Sorry about that. I have spent a couple of hours this morning resolving the issue 15cdb6b

1.96 just uploaded to CPAN

[skaji]

@bingos Thanks!