Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make evaluation/intro more user-friendly #680

Merged
merged 2 commits into from
May 30, 2023
Merged

Make evaluation/intro more user-friendly #680

merged 2 commits into from
May 30, 2023

Conversation

nikpag
Copy link
Collaborator

@nikpag nikpag commented May 28, 2023

This PR makes the evaluation/intro first-time experience a little more straightforward by:

  • Adding a README that prompts the user to create required input files beforehand, in case they decide to run the evaluation scripts (such as demo-spell.sh) separately, as opposed to running test.sh directly.
  • Fixing a problem with curl that caused the 100M.txt file to be empty when the data was fetched from www.gutenberg.org.

@github-actions
Copy link

OS:ubuntu-20.04
Sun May 28 16:38:35 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

Signed-off-by: Nikos Pagonas <nikospagonas00@gmail.com>
Signed-off-by: Nikos Pagonas <nikospagonas00@gmail.com>
@github-actions
Copy link

OS:ubuntu-20.04
Tue May 30 19:58:01 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :) It looks great, the issue with the POSIX test has to do with the fact that you did the changes in your own fork (our current CI doesn't support that). Since the change is not pervasive I will just merge!

@angelhof angelhof merged commit 39acf2b into binpash:main May 30, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants