Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested mount support #67

Merged
merged 30 commits into from
Jun 29, 2023
Merged

Nested mount support #67

merged 30 commits into from
Jun 29, 2023

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jun 26, 2023 •
edited by gliargovas
Loading

  • mergerfs-fuse support @ericzty
  • unionfs-fuse support @ericzty
  • auto detect available fuse impl @ericzty
  • flag to specify fuse impl path @ericzty
  • update readme @ericzty
  • update manpage @gliargovas
  • update completions @gliargovas
  • test to see we can read from /run/systemd @gliargovas

@ezrizhu ezrizhu self-assigned this Jun 26, 2023
@ezrizhu ezrizhu linked an issue Jun 26, 2023 that may be closed by this pull request
Unshare fails on nested mounts #19
Closed
@mgree mgree mentioned this pull request Jun 26, 2023
Open
@mgree
Copy link
Contributor

mgree commented Jun 26, 2023 •
edited by gliargovas
Loading

  • update manpage
  • update completions

😁

This was linked to issues Jun 26, 2023
Warning when mounting run #20
Closed
/run not being mounted as readonly #56
Closed
@ezrizhu ezrizhu linked an issue Jun 27, 2023 that may be closed by this pull request
Fail early when critical commands are missing #45
Closed
@angelhof angelhof mentioned this pull request Jun 28, 2023
Closed
@angelhof angelhof mentioned this pull request Jun 28, 2023
Closed
@ezrizhu ezrizhu linked an issue Jun 28, 2023 that may be closed by this pull request
problems when there are top level filesystem mount points #38
Closed
@ezrizhu ezrizhu requested review from mgree and angelhof June 29, 2023 05:39
@gliargovas
Copy link
Collaborator

@mgree @angelhof this is ready for review

angelhof
angelhof requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot everyone! I have left some code quality comments, I can also help with fixing them if you want!

try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
try Outdated Show resolved Hide resolved
@angelhof
Copy link
Member

Fixed merge conflicts with main but now a test fails, I will figure it out in about an hour!

angelhof
angelhof approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge after we write a more thorough comment explaining why mergerfs/unionfs solution works :)

@angelhof angelhof changed the title [WIP] nested mount support Nested mount support Jun 29, 2023
mgree
mgree approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Applied a few copyedits.

@ezrizhu ezrizhu merged commit abe88f3 into main Jun 29, 2023
6 checks passed
@ezrizhu ezrizhu deleted the nested-mount branch June 29, 2023 17:07
@mgree mgree mentioned this pull request Jul 6, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree mgree approved these changes

@angelhof angelhof angelhof approved these changes

Assignees

@ezrizhu ezrizhu

@gliargovas gliargovas

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ezrizhu @mgree @gliargovas @angelhof