Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try explore #79

Merged
merged 20 commits into from
Jun 29, 2023
Merged

Try explore #79

merged 20 commits into from
Jun 29, 2023

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jun 27, 2023

  • Add try explore to readme
  • Use current shell with try explore

Closes #5

@ezrizhu ezrizhu requested a review from mgree June 27, 2023 18:10
@ezrizhu ezrizhu self-assigned this Jun 27, 2023
angelhof
angelhof approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Is the main usecase to run try explore or to run try explore SANDBOX to open the shell in an existing sandbox. If is is the second, the README should be modified to reflect it :)

@ezrizhu
Copy link
Collaborator Author

ezrizhu commented Jun 27, 2023

This looks good to me! Is the main usecase to run try explore or to run try explore SANDBOX to open the shell in an existing sandbox. If is is the second, the README should be modified to reflect it :)

Good idea, readme updated!

mgree
mgree requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A tiny nit, and then we should update the manpage and completion, too.

README.md Outdated Show resolved Hide resolved
try Show resolved Hide resolved
@angelhof
Copy link
Member

Added a test (see #77). It works locally, does anyone have any idea why it might fail on the CI?

@angelhof
Copy link
Member

It looks like it's working now, but we should make a few more commits to retest it!

@angelhof angelhof merged commit 6059bac into main Jun 29, 2023
6 checks passed
@angelhof angelhof deleted the try-explore branch June 29, 2023 13:37
@angelhof angelhof mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree mgree requested changes

@angelhof angelhof angelhof approved these changes

Assignees

@ezrizhu ezrizhu

@gliargovas gliargovas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try explore to launch a shell
4 participants
@ezrizhu @angelhof @mgree @gliargovas