Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support Struct Syncing in Binja #122

Closed
Lukas-Dresel opened this issue Apr 18, 2022 · 1 comment
Closed

Feat: Support Struct Syncing in Binja #122

Lukas-Dresel opened this issue Apr 18, 2022 · 1 comment
Labels
binary ninja enhancement New feature or request

Comments

@Lukas-Dresel
Copy link
Contributor

Open phonebook in binja, sync person_t from the globals tab

  File "/home/honululu/lukas/tools/binsync/binsync/common/ui/tables/ctx_table.py", line 110, in <lambda>
    menu.addAction("Sync", lambda: self.controller.fill_function(func_addr, user=username))
  File "/home/honululu/lukas/tools/binsync/binsync/common/controller.py", line 26, in initcheck
    return f(self, *args, **kwargs)
  File "/home/honululu/lukas/tools/binsync/binsync/common/controller.py", line 93, in state_check
    return f(self, *args, **kwargs)
  File "/home/honululu/.binaryninja/plugins/binja_binsync/controller.py", line 159, in fill_function
    type_, _ = bn_func.view.parse_type_string(stack_var.type)
  File "/home/honululu/lukas/tools/binja/binaryninja/plugins/../python/binaryninja/binaryview.py", line 6173, in parse_type_string
    raise SyntaxError(error_str)
SyntaxError: input:1: error: type 'person_t' is not defined
Traceback (most recent call last):
  File "/home/honululu/lukas/tools/binsync/binsync/common/ui/tables/globals_table.py", line 110, in <lambda>
    filler_func = lambda: self.controller.fill_struct(global_name, user=user_name)
  File "/home/honululu/lukas/tools/binsync/binsync/common/controller.py", line 26, in initcheck
    return f(self, *args, **kwargs)
  File "/home/honululu/lukas/tools/binsync/binsync/common/controller.py", line 93, in state_check
    return f(self, *args, **kwargs)
  File "/home/honululu/lukas/tools/binsync/binsync/common/controller.py", line 315, in fill_struct
    raise NotImplementedError
NotImplementedError
@mahaloz mahaloz changed the title NotImplementedError when syncing into Binja Feat: Support Struct Syncing in Binja Jun 6, 2022
@mahaloz mahaloz added enhancement New feature or request binary ninja labels Jun 6, 2022
@mahaloz
Copy link
Member

mahaloz commented Feb 27, 2023

Forgot to close this with #201

@mahaloz mahaloz closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary ninja enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants