fix wrong reraise value, fix #578

binux · Nov 21, 2016 · d220598 · d220598
1 parent 4b89fec
commit d220598
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pyspider/libs/response.py b/pyspider/libs/response.py
@@ -167,7 +167,7 @@ def raise_for_status(self, allow_redirects=True):
             return
         elif self.error:
             if self.traceback:
-                six.reraise(Exception, self.error, Traceback.from_string(self.traceback).as_traceback())
+                six.reraise(Exception, Exception(self.error), Traceback.from_string(self.traceback).as_traceback())
             http_error = HTTPError(self.error)
         elif (self.status_code >= 300) and (self.status_code < 400) and not allow_redirects:
             http_error = HTTPError('%s Redirection' % (self.status_code))

diff --git a/tests/test_response.py b/tests/test_response.py
@@ -88,3 +88,8 @@ def test_60_not_ok(self):
         response = self.get('/status/600')
         self.assertFalse(response.ok)
         self.assertFalse(response)
+
+    def test_70_reraise_exception(self):
+        response = self.get('file://abc')
+        with self.assertRaisesRegexp(Exception, 'HTTP 599'):
+            response.raise_for_status()