Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rate-Topics header to WebSocket connection and JSON stream #55

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented Mar 5, 2023

@binwiederhier
Copy link
Owner

So here are my unfiltered thoughts: Would "rate topics" be useful outside of unifiedpush maybe in the future? Like, would it be useful to say "this is a rate topic, I will be take all the rate limits for the messages that come in" to a user?

I am not saying that we should implement this feature, just maybe that in the code we call them "rateTopics"? Thoughts?

@wunter8
Copy link
Contributor Author

wunter8 commented Mar 7, 2023

Since it's correct for the current use case, I'd say don't change it now because we might want something different later. I think if we implement the new feature in the future, we can change the terminology then? 🤷‍♂️

@binwiederhier
Copy link
Owner

Fair enough

@binwiederhier binwiederhier merged commit 3c86c7a into binwiederhier:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: Add Rate-Topics: header to UnifiedPush subscriptions
2 participants