Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android app: action button with action "http" and method GET produces incorrect error #221

Closed
cmeis opened this issue Apr 23, 2022 · 1 comment
Labels
android-app ntfy Android app 🪲 bug Something isn't working in-progress 🏃 I'm working on this right now

Comments

@cmeis
Copy link
Contributor

cmeis commented Apr 23, 2022

The Android test app (test build from Discord / https://phil.nopaste.net/T7d7JOvNRH?d=1&f=app-play-debug.apk&a=uVxXKVl4wn) is behaving incorrectly with an action button of type "http" and method set to "GET".
The notification is sent to the app.
When clicking the action button in the notification the request is not sent and an error message is displayed: "unlock door failed: method GET must not have a request body" - but there is no request body defined.

This is an example notification request:

{
    "topic": "transfer",
    "message": "pizza delivery arrived",
    "actions": [
      {
        "action": "http",
        "label": "unlock door",
        "url": "https://my.door.lock/open-sesame",
        "method": "GET",
        "clear": true
      }
    ]
  }
@binwiederhier binwiederhier added 🪲 bug Something isn't working android-app ntfy Android app in-progress 🏃 I'm working on this right now labels Apr 23, 2022
@binwiederhier
Copy link
Owner

Fixed in b805d49 and binwiederhier/ntfy-android@4ad6846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app ntfy Android app 🪲 bug Something isn't working in-progress 🏃 I'm working on this right now
Projects
None yet
Development

No branches or pull requests

2 participants