Attachment shows "link expired" for external attachments

[binwiederhier]

In the case below, the attachment can only be downloaded from the notification action button, but not from the ntfy detail view.

curl -d "Here's a notification with an .apk attachment" -H "Attach: https://f-droid.org/repo/com.calcitem.sanmill_3178.apk" -H p:4 ntfy.sh/demogoogle

Here's a video+screenshot showing the issue. The first attempt in the video works, the following attempts do not: https://photos.app.goo.gl/mKAEyh7VYyWBmtaW6

[binwiederhier]

I think this is a Firebase-only bug. Top one received via instant delivery, bottom via Firebase:

[binwiederhier]

It's because attachment_expires=0:

2022-12-04 23:11:45.920 2619-5880/io.heckel.ntfy D/NtfyFirebase: Received message: from=/topics/demogoogle, fcmprio=1, fcmprio_orig=1, data={priority=4, attachment_name=com.calcitem.sanmill_3178.apk, attachment_size=0, attachment_type=, attachment_expires=0, id=lpClKDAT6eJz, icon=, tags=, time=1670213505, click=, event=message, title=, topic=demogoogle, attachment_url=https://f-droid.org/repo/com.calcitem.sanmill_3178.apk, message=Here's a notification with an .apk attachment, encoding=}

[binwiederhier]

Fixed in binwiederhier/ntfy-android@b91778a