[SMTP] Allow unsecured mailservers

[sharknoon]

Hello,

I have ntfy deployed in a containerized environment with docker. There I have an external mailserver (SMTP) that is only accessible via a docker network. My mailserver has no authentification, because it is not public. Only containers in the same network can access it.

When I leave the field smtp-sender-user / smtp-sender-pass blank, the error is the following:

Mismatched type for flag 'smtp-sender-user'. Expected 'string' but actual is ''

When I comment it out, the error is the following:

if smtp-sender-addr is set, base-url, smtp-sender-user, smtp-sender-pass and smtp-sender-from must also be set

This error comes from here.

I would be very happy, if we would allow mailservers without auth. Especially for cases, where the mailserver is exclusive to ntfy by being bundled in the same docker-compose network.

Btw Thank you @binwiederhier for making such a great app and putting so much effort in it, I am loving ntfy :)

Kind regards from the southwest of germany (Stuttgart)

Sharknoon

[binwiederhier]

I implemented this in 90db128

Sadly I do not have an SMTP server without to test this with, but I'm pretty sure it'll work. If you know how to build ntfy, you can build the latest main branch. If not, I built an amd64 version for you here:

curl https://ntfy.sh/file/gEmVMKDSMFTI.bin > ntfy-snap
chmod +x ntfy-snap
./ntfy-snap

[binwiederhier]

I'm closing this ticket since I assume it works, If it doesn't, please let me know.

[sharknoon]

Thank you so much for your very fast implementation. I was already working on a pull request, made the same changes, but you were faster :) Thanks!

[binwiederhier]

I'm sorry I took that from you. It just felt so easy, and I sometimes like doing easy things inbetween all the weird and complicated stuff.