UTF-8 Actions Header

[cfouche3005]

🐞 Describe the bug

Ntfy server seem to block every POST request with an UTF-8 character ( à ) inside the Actions Header (for the label) but when I had an an UTF-8 character inside the Title Header or the body, it is processed normally and give the correct output or an unknow character due to bad UTF-8 processing (not a bug, I think)

💻 Components impacted

Ntfy Server

💡 Screenshots and/or logs

ntfy server log:

2023/05/20 18:02:55 DEBUG Connection closed with HTTP 400 (ntfy error 40018) (error=invalid request: actions invalid; invalid utf-8 string, error_code=40018, http_method=POST, http_path=/Netbird, http_status=400, tag=http, topic=Netbird, topic_last_access=2023-05-20T18:02:44.21Z, topic_subscribers=1, user_id=u_Iyy0BJTPUR, user_name=cfouche, visitor_auth_limiter_limit=0.016666666666666666, visitor_auth_limiter_tokens=30, visitor_emails=0, visitor_emails_limit=24, visitor_emails_remaining=24, visitor_id=ip:REDACTED, visitor_ip=REDACTED, visitor_messages=0, visitor_messages_limit=17280, visitor_messages_remaining=17280, visitor_request_limiter_limit=0.2, visitor_request_limiter_tokens=59.000016648, visitor_seen=2023-05-20T18:02:55.92Z)

Actions Header : http, "Mettre à jour", "https://REDACTED/webhook/netbird-update", method=GET, headers.AUTH=REDACTED

🔮 Additional context

I can't use the JSON method because I need the Icon parameter and it isn't supported

[binwiederhier]

UTF-8 headers are supported by the ntfy server, but many clients have trouble with it. So it is likely that your IDE and/or programming language is incorrectly encoding the header. This is because the HTTP spec doesn't officially support UTF-8 header.

It works on Linux with curl:

$ curl -d "hi there" -H 'Actions: http, "Mettre à jour", "https://REDACTED/webhook/netbird-update", method=GET, headers.AUTH=REDACTED' ntfy.sh/test12
{"id":"3CSBNE1cyHEh","time":1684704669,"expires":1684747869,"event":"message","topic":"test12","message":"hi there","actions":[{"id":"4jvCVVB6D4","action":"http","label":"Mettre à jour","clear":false,"url":"https://REDACTED/webhook/netbird-update","method":"GET","headers":{"AUTH":"REDACTED"}}]}

That said, a few of the other headers can already be encoded with RFC 2047 type strings, but the action description cannot. Maybe we should add that support too. Then you could do:

http, "=?utf-8?q?Mettre =C3=A0 jour?=", "https://REDACTED/webhook/netbird-update"

I think that's reasonable.

I can't use the JSON method because I need the Icon parameter and it isn't supported

The icon param should be supported. Here's and example with curl:

$ curl -d '{"topic":"test123","icon":"http://some.icon.org/hi.jpg"}' ntfy.sh
{"id":"WCDj1GfaF6H4","time":1684705371,"expires":1684748571,"event":"message","topic":"test123","message":"triggered","icon":"http://some.icon.org/hi.jpg"}

[cfouche3005]

That said, a few of the other headers can already be encoded with RFC 2047 type strings, but the action description cannot. Maybe we should add that support too.

Yes, It would be very nice.

The icon param should be supported.

It was not inside the overview of the supported field of the documentation so I thought it was not supported
https://docs.ntfy.sh/publish/#publish-as-json

[binwiederhier]

Done in 168ad8b -- Will be in the next release