Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apprise support #99

Closed
binwiederhier opened this issue Jan 17, 2022 · 16 comments
Closed

apprise support #99

binwiederhier opened this issue Jan 17, 2022 · 16 comments
Labels
enhancement New feature or request in-progress 🏃 I'm working on this right now

Comments

@binwiederhier
Copy link
Owner

https://github.com/caronc/apprise

@binwiederhier binwiederhier added the enhancement New feature or request label Jan 17, 2022
@onedr0p
Copy link

onedr0p commented Jan 17, 2022

Apprise is specifically Python, I think you want the Go equivalent:

https://github.com/containrrr/shoutrrr

@bt90
Copy link
Contributor

bt90 commented Jan 17, 2022

Not really. Apprise is used by a lot of projects. This would add ntfy support to HomeAssistant, changedetection, uptime-kuma, bazarr, radarr, nzbget and a few other projects.

see https://github.com/caronc/apprise/wiki/showcase#integrations

Edit: adding shoutrrr support would be nice, too

@onedr0p
Copy link

onedr0p commented Jan 17, 2022

What I meant to say is, apprise is a Python library and works best integrated into apps that are written in Python.

Let's take Uptime Kuma (which is written in JS) as an example,

let s = child_process.spawnSync("apprise", [ "-vv", "-b", msg, notification.appriseURL])

This is pretty bad practice IMO, you do not want to have you application depend on calling an external app like this. However this is up to the developer here. I suggested shoutrrr because it's the closest thing to an apprise library in written in Go.

@bt90
Copy link
Contributor

bt90 commented Jan 17, 2022

This ticket is about upstream apprise support. e.g using ntfy as a notification backend in uptime kuma.

@onedr0p
Copy link

onedr0p commented Jan 17, 2022

Wouldn't that issue have to be opened in the apprise (and possibly shoutrrr) repositories to support nfty?

@bt90
Copy link
Contributor

bt90 commented Jan 17, 2022

I think @binwiederhier is free to handle this as he pleases.

@binwiederhier
Copy link
Owner Author

binwiederhier commented Jan 18, 2022

I added a ticket in the apprise issue tracker (caronc/apprise#520). I can probably do it myself, but it'll take me much much longer than if the maintainer does it. Let's see what they say.

@caronc
Copy link

caronc commented Jan 21, 2022

I added a ticket in the apprise issue tracker (caronc/apprise#520). I can probably do it myself, but it'll take me much much longer than if the maintainer does it. Let's see what they say.

I'll just comment right in here; i love it. The only problem is that my full time job sucks a lot of my time these days. But I'll do my best. In the meantime, if you do feel eager enough to try the PR yourself, go for it. I've documented a quick how-to-build an plugin. Even if you can get one barely working, i'll be able to muster enough strength to cover unit tests around it and complete the MR for you if you get stuck.

But if you meet me half way here, you'll see the integration much, much faster! ❤️ .

Thanks for showing interest in Apprise!

@binwiederhier
Copy link
Owner Author

binwiederhier commented Jan 21, 2022

Thanks for the kind words. I love apprise too. Multiple people have shown interest and actually, my co-worker, @particledecay, is already working on the integration/plugin. And now that I tagged you Joey you have to deliver :-)))

@binwiederhier
Copy link
Owner Author

WIP PR caronc/apprise#524

@binwiederhier binwiederhier added the in-progress 🏃 I'm working on this right now label Jan 26, 2022
@binwiederhier
Copy link
Owner Author

Any news, @particledecay? 😬 ❤️

@particledecay
Copy link

Out of town this weekend, but close. Was stepping through some of the plugin loading code to figure out why it wasn't detecting, but pretty sure I figured it out.

@particledecay
Copy link

@caronc hey calling out for some help if possible. I've got the notifications working, and I'm trying to support priority at the moment but I couldn't find the answer in the plugin doc. Also didn't see priority in the other docs. A plugin reference would be super helpful in this case, but I'll take a quick answer if you have one!

@binwiederhier
Copy link
Owner Author

@particledecay Do you need any help from me? If you can't find the time to finish I can probably take over. No worries :D

@binwiederhier
Copy link
Owner Author

This has been merged to master in Apprise and will likely be released in the next Apprise release.

@otbutz
Copy link

otbutz commented Dec 28, 2022

Apprise is specifically Python, I think you want the Go equivalent:

https://github.com/containrrr/shoutrrr

containrrr/shoutrrr#308

A bit offtopic, but shoutrrr support is being worked on, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress 🏃 I'm working on this right now
Projects
None yet
Development

No branches or pull requests

6 participants