Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SecurityDefinitions type for _componentsSecuritySchemes #32

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Use SecurityDefinitions type for _componentsSecuritySchemes #32

merged 3 commits into from
Dec 12, 2021

Commits on Nov 24, 2021

  1. Use SecurityDefinitions newtype in Components 

    Problem: there is `SecurityDefinitions` newtype which is unused.
Long ago it was used to store security schemas, but then in 821654c
the corresponding field changed to `Definitions SecurityScheme`.
There is one essential difference caused by this change: now if we
mappend two `Components` (or other types that hold `Components`
inside) and both sides have `SecuritySchemeOAuth2`, they won't be
merged.

Solution: change `_componentsSecuritySchemes` to `SecurityDefinitions`.
    @gromakovsky
    gromakovsky committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    00aae14 View commit details
    Browse the repository at this point in the history

  2. Add tests for merging security schemes 

    When we concatenate OpenApi objects, we want security schemes
to be merged deeply, so that if there are 2 `OAuth2Flows` in
`SecuritySchemeOAuth2`, they are concatenated.
Previously it wasn't tested and was failing without the previous
fix. The new test concatenates two `OpenApi` objects with
`SecuritySchemeOAuth2`.
    @gromakovsky
    gromakovsky committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    da203c1 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @gromakovsky
    gromakovsky committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a2e6895 View commit details
    Browse the repository at this point in the history