Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for doctest on GHC 9.4 #61

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Aug 15, 2022

Fixes

Tested using

cabal test --enable-tests -w ghc-9.4.2 --constraint='vector>=0.13' --constraint='lens>=5.2' --constraint='aeson>=2.1'

The tests can't be run because doctest doesn't support GHC 9.4 yet.

@pwm
Copy link

pwm commented Oct 1, 2022

Gentle ping @maksbotan could we please get this merged?

@ysangkok
Copy link
Contributor Author

ysangkok commented Oct 2, 2022

@pwm It would be best if sol/doctest#382 was finished first, then we could test this in CI.

@eddiejessup
Copy link

Hi, just letting you know that doctest has a release supporting 9.4 now

@ysangkok ysangkok changed the title Bump dependencies: base, template-haskell, aeson, lens, vector doctest v0.20.1 (GHC 9.4) support and bumped dependencies: base, template-haskell, aeson, lens, vector Oct 19, 2022
@ysangkok
Copy link
Contributor Author

@maksbotan Doctest supports GHC 9.4 now, so I think this is ready for review.

@endgame
Copy link

endgame commented Oct 23, 2022

As a Hackage Trustee, I have made the following revisions to openapi3-3.2.2:

  • aeson: >=1.4.2.0 && <1.6 || >=2.0.1.0 && <2.1 -> >=1.4.2.0 && <1.6 || >=2.0.1.0 && <2.2
  • base: >=4.11.1.0 && <4.17 -> >=4.11.1.0 && <4.18
  • lens: >=4.16.1 && <5.2 -> >=4.16.1 && <5.3
  • template: >=2.13.0.0 && <2.19 -> >=2.13.0.0 && <2.20
  • vector: >=0.12.0.1 && <0.13 -> >=0.12.0.1 && <0.14

maksbotan added a commit that referenced this pull request Oct 26, 2022
maksbotan added a commit that referenced this pull request Oct 26, 2022
@maksbotan
Copy link
Collaborator

Hi! Sorry for the lag!

I've incorporated @endgame's revision into master branch.

@maksbotan
Copy link
Collaborator

@ysangkok I've added 9.4 CI to this branch and doctests fail:

/__w/openapi3/openapi3/unpacked/openapi3-3.2.2/src/Data/OpenApi/Schema/Validation.hs:38: failure in expression `import Data.OpenApi'
expected: 
 but got: 
          ^
          <interactive>:1:1: error:
              attempting to use module ‘main:Data.OpenApi’ (/__w/openapi3/openapi3/unpacked/openapi3-3.2.2/src/Data/OpenApi.hs) which is not loaded

/__w/openapi3/openapi3/unpacked/openapi3-3.2.2/src/Data/OpenApi/Internal/Schema/Validation.hs:63: failure in expression `import Data.OpenApi.Internal.Schema.Validation'
expected: 
 but got: 
          ^
          <interactive>:1:1: error:
              attempting to use module ‘main:Data.OpenApi.Internal.Schema.Validation’ (/__w/openapi3/openapi3/unpacked/openapi3-3.2.2/src/Data/OpenApi/Internal/Schema/Validation.hs) which is not loaded

Can you look into this please?

@ysangkok
Copy link
Contributor Author

@maksbotan I spent a couple of hours and reported sol/doctest#389 . I think the error in Data.OpenApi.Internal.Schema.Validation is related to OverloadedLists. But I don't wanna spend more time on this, I think doctest is super fragile and not worth the effort. Feel free to close this PR.

@ysangkok ysangkok changed the title doctest v0.20.1 (GHC 9.4) support and bumped dependencies: base, template-haskell, aeson, lens, vector Updated for doctest on GHC 9.4 Oct 29, 2022
@maksbotan
Copy link
Collaborator

@ysangkok thanks for the discovery! I've replaced OverloadedLists usage with explicit IOHM.fromList, now tests pass on 9.4 🎉

@maksbotan maksbotan merged commit cffc5eb into biocad:master Nov 19, 2022
@ysangkok ysangkok deleted the janus/ghc-9.4 branch November 19, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants