Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug parsing set of valid OpenApi spec versions #68

Merged
merged 2 commits into from Nov 19, 2022

Conversation

tonicebrian
Copy link
Contributor

The library was lacking the mandatory field openapi as a root element. This wasn't required before because version was fixed at 3.0.0. This PR is intended to allow parsing all versions in the 3.0.x range and closes #64

@maksbotan maksbotan self-requested a review October 29, 2022 05:41
Copy link
Collaborator

@maksbotan maksbotan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is OK! I'll merge after these cosmetic changes.

src/Data/OpenApi/Internal.hs Outdated Show resolved Hide resolved
src/Data/OpenApi/Internal.hs Outdated Show resolved Hide resolved
@maksbotan maksbotan merged commit ac7058e into biocad:master Nov 19, 2022
@maksbotan
Copy link
Collaborator

Thanks! I'll release this on Hackage after #43 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when parsing newer OpenApi3 schemas
2 participants