update for NumPy 2.0 #173
Merged
update for NumPy 2.0 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests are failing, but it looks like they are very old versions of Python. Probably need to be updated... |
|
Thanks! I'll update the unit tests and try to fix the Cython error. |
|
Fixed in murrayrm#1 |
Fix for Cython error in PR biocircuits#173 on Bioscrape
|
@ayush9pandey Looks like we are still checking against Python 3.7 and getting an error. |
|
Yes, it's failing on Mac OS because it seems that it's defaulting to arm64 architecture for Mac OS now. It should work if we fix the architecture to x64 when testing on mac-os, with py3.7. Fixing it.. |
ayush9pandey
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates bioscrape to work with NumPy 2.0 and seems to be mainly working on Python 3.12.
There is an error in one of the unit tests associated with Cython 3.0's handling of **. The error message says that we need to set the compiler directive 'cpow(True)', but I was not able to do this.
Posting this how so that @ayush9pandey can see if this addresses issue #172.