Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hgvs requires pysam via seqrepo; dependency should be optional #522

Closed
khmccurdy opened this issue Sep 20, 2018 · 6 comments
Closed

hgvs requires pysam via seqrepo; dependency should be optional #522

khmccurdy opened this issue Sep 20, 2018 · 6 comments
Labels
closed-by-stale stale Issue is stale and subject to automatic closing

Comments

@khmccurdy
Copy link
Contributor

In my brief research, I came across a pysam fork designed to run on Windows: https://pypi.org/project/pysam-win/ (in reference to #470 )
I have not had the opportunity to test it yet, and likely will not have the ability to compare the two libraries myself, but I believe this may be worth investigating in the interest of expanding OS compatibility.

@reece
Copy link
Member

reece commented Sep 20, 2018

Thanks, Kevin.

There are two things going on here. pysam is getting pulled in by seqrepo, which really should be optional (#523).

The second is issue you've identified regarding pysam on windows. Given that the challenge is really with seqrepo, would you please create a new issue in that repo, reference it in this hgvs issue, and then close it here?

Thanks!

@khmccurdy
Copy link
Contributor Author

Issue moved to biocommons/biocommons.seqrepo#32.

@reece
Copy link
Member

reece commented Oct 21, 2018

Status: hgvs currently requires seqrepo, which in turn requires pysam. That means that it's impossible to install hgvs without installing pysam.

Plan: make seqrepo optional in hgvs (with extras_require). This will create a breaking change because current users of hgvs with seqrepo will now have to specify seqrepo manually on installation.

@reece reece changed the title Potential pysam workaround for improved Windows compatibility hgvs requires pysam via seqrepo; dependency should be optional Oct 21, 2018
@khmccurdy
Copy link
Contributor Author

If it works within the confines of a setup program, Python has the ability to check which OS it's running in. Maybe the setup could consider seqrepo required or optional depending on whether it's on Windows?

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Feb 26, 2024
Copy link

github-actions bot commented Mar 5, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
biocommons roadmap automation moved this from Backlog to Done Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-by-stale stale Issue is stale and subject to automatic closing
Projects
Development

No branches or pull requests

2 participants