Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify script_access_type vs script #26

Closed
stain opened this issue Nov 7, 2018 · 2 comments
Closed

Clarify script_access_type vs script #26

stain opened this issue Nov 7, 2018 · 2 comments
Labels
discuss Discussion/opinions requested

Comments

@stain
Copy link
Member

stain commented Nov 7, 2018

script_access_type feels a bit contrived, as it is defining the type of script key, making it hard to validate/use alone.

The script key however does not explain at all how an inline script can be used.

Other parts of BCO use sub-objects like

 "source": {
    "address": "http://example.com/file.txt"
}

It might make sense to do a similar approach here, where one can provide either address for URI (potentially relative #23 for files) or value for inline scripts (but preferably not both!) - thus one can remove script_access_type

@jpat1546 jpat1546 added the discuss Discussion/opinions requested label Nov 15, 2018
@jpat1546
Copy link
Contributor

Relates to #50

@HadleyKing HadleyKing mentioned this issue Nov 28, 2018
6 tasks
@HadleyKing
Copy link
Contributor

See #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discussion/opinions requested
Projects
None yet
Development

No branches or pull requests

3 participants