Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Domain #50

Closed
6 tasks done
HadleyKing opened this issue Nov 27, 2018 · 4 comments · Fixed by #60
Closed
6 tasks done

Execution Domain #50

HadleyKing opened this issue Nov 27, 2018 · 4 comments · Fixed by #60

Comments

@HadleyKing
Copy link
Contributor

HadleyKing commented Nov 27, 2018

Issues from execution-domain

  • Maybe script_access_type and script properities can be tied together (Clarify script_access_type vs script  #26)
  • script.uri
    URI values require regex
  • pipeline_version should not be required (is listed as required in schema)
    (maybe it is not necessary here)
  • platform maybe not needed in this domain

In general, this domain needs more refinement

  • domain_prerequisites should be renamed (maybe "data_endpoint")
    domain_prerequisites.name should also be renamed
    regex for domain_prerequisites.url
  • env_parameters should a simple dictionary of a list of dictionaries
    Should avoid saying "Environmental parameters" --> should be environment variables
HadleyKing added a commit that referenced this issue Nov 30, 2018
Removed `pipeline_version` fixes #27
apply to #50
HadleyKing added a commit that referenced this issue Dec 5, 2018
env_parameters should a simple dictionary of a list of dictionaries.
Should avoid saying "Environmental parameters" --> should be environment variables
apply #50
HadleyKing added a commit that referenced this issue Dec 5, 2018
env_parameters should a simple dictionary of a list of dictionaries.
Should avoid saying "Environmental parameters" --> should be environment variables
apply #50
@corburn
Copy link
Contributor

corburn commented Dec 5, 2018

@HadleyKing in regards to 98c53dc resolving extra-validation-items-execution-domain.md:

  1. env_parameters should a simple dictionary of a list of dictionaries Should avoid saying "Environmental parameters" --> should be environment variables

It looks like the idea was to change this:

"env_parameters": [{
    "key": "HOSTTYPE", 
    "value" : "x86_64-linux"
}]

to this:

"environment_variables": {
    "HOSTTYPE": "x86_64-linux",
    "EDITOR": "vim",
    "FOO_BAR": "baz_quox"
}

@HadleyKing
Copy link
Contributor Author

@corburn
ok. How would that look in the schema? I was unsure of how to implement that.

@HadleyKing
Copy link
Contributor Author

HadleyKing commented Dec 5, 2018

@corburn

Issues from execution-domain

I was also trying to implement some sort of enum or oneOf for the script field to accommodate the possibility of two different types (e.g. uri or text) and referencing them as #definition, but could not get it to work. I think that would allow us to combine these fields into one. It would also solve the bullet below too... I think.

  • script.uri
    URI values require regex

@corburn
Copy link
Contributor

corburn commented Dec 5, 2018

@HadleyKing

environment_variables schema:

    "environment_variables": {
      "type": "object",
      "description": "Environmental parameters that are useful to configure the execution environment on the target platform.",
      "additionalProperties": false,
      "patternProperties": {
        "^[a-zA-Z_]+[a-zA-Z0-9_]*$": {
          "type": "string"
        }
      }
    }

The regex is based on the following:

http://pubs.opengroup.org/onlinepubs/000095399/basedefs/xbd_chap08.html
Environment variable names used by the utilities in the Shell and Utilities volume of IEEE Std 1003.1-2001 consist solely of uppercase letters, digits, and the '_' (underscore) from the characters defined in Portable Character Set and do not begin with a digit. Other characters may be permitted by an implementation; applications shall tolerate the presence of such names. Uppercase and lowercase letters shall retain their unique identities and shall not be folded together. The name space of environment variable names containing lowercase letters is reserved for applications. Applications can define any environment variables with names from this name space without modifying the behavior of the standard utilities.

Note:
Other applications may have difficulty dealing with environment variable names that start with a digit. For this reason, use of such names is not recommended anywhere.

script and script_access_type

I would drop script_access_type and define script simply as a URI:

https://tools.ietf.org/html/rfc8089
file://path/to/rfc8089.txt

"script": {
    "$ref": "#/definitions/uri"
}

HadleyKing added a commit that referenced this issue Dec 5, 2018
… MD.2

env_parameters should a simple dictionary of a list of dictionaries.
Should avoid saying "Environmental parameters" --> should be environment variables
apply #50
HadleyKing added a commit that referenced this issue Dec 6, 2018
apply #49 #48 #50 #51
Define a BCO specific `uri` object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants