Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ntCard to 1.2.0 #19965

Merged
merged 4 commits into from Jan 27, 2020
Merged

update ntCard to 1.2.0 #19965

merged 4 commits into from Jan 27, 2020

Conversation

jwcodee
Copy link
Contributor

@jwcodee jwcodee commented Jan 24, 2020

Update ntCard to version 1.2.0


Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences
    (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

  • @BiocondaBot please update will cause the BiocondaBot to merge the master branch into a PR
  • @BiocondaBot please add label will add the please review & merge label.
  • @BiocondaBot please fetch artifacts will post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.

For members of the Bioconda project, the following command is also available:

  • @BiocondaBot please merge will cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.

If you have questions, please post them in gitter or ping @bioconda/core in a comment (if you are not able to directly ping @bioconda/core then the bot will repost your comment and enable pinging).

@jwcodee
Copy link
Contributor Author

jwcodee commented Jan 24, 2020

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jan 24, 2020
@npavlovikj
Copy link
Member

This recipe is blacklisted and hasn't been built:

23:33:22 BIOCONDA INFO Considering total of 7007 recipes.
23:33:22 BIOCONDA INFO Constraining to 1 git modified recipes (ntcard).
23:33:22 BIOCONDA INFO Ignoring 1 blacklisted recipes (ntcard).
23:33:22 BIOCONDA INFO Processing 0 recipes.
23:33:23 BIOCONDA INFO Nothing to be done.

Please remove it from build-fail-blacklist and try again.

@jwcodee
Copy link
Contributor Author

jwcodee commented Jan 27, 2020

@npavlovikj

Solved the CI issues. Can you review again? Thanks

@npavlovikj
Copy link
Member

@jowong4 , since llvm-openmp is needed only for OSX, I would suggest you to use llvm-openmp # [osx] in the requirements section. Other than that, the recipe looks good, and I can merge it afterwards.

@jwcodee
Copy link
Contributor Author

jwcodee commented Jan 27, 2020

Thanks for reviewing

@npavlovikj
Copy link
Member

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-64 ntcard-1.2.0-he513fc3_0.tar.bz2 repodata.json
osx-64 ntcard-1.2.0-h2dec4b4_0.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on linux-64:
conda install -c https://92298-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
  • For packages on osx-64:
conda install -c https://92300-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag Install with docker
ntcard 1.2.0--he513fc3_0
showcurl "https://92298-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/ntcard%3A1.2.0--he513fc3_0.tar.gz" | gzip -dc | docker load

@npavlovikj
Copy link
Member

@BiocondaBot please merge

@npavlovikj
Copy link
Member

Thank for fixing this recipe, and contributing @jowong4 🎉

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 4fdb534 into bioconda:master Jan 27, 2020
@jwcodee jwcodee deleted the patch-6 branch January 27, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants