Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to update to RepeatMasker 4.1.0 using new configure #21155

Closed
wants to merge 8 commits into from
Closed

Try to update to RepeatMasker 4.1.0 using new configure #21155

wants to merge 8 commits into from

Conversation

Juke34
Copy link
Contributor

@Juke34 Juke34 commented Mar 27, 2020

Update to new version and Simplification of the old recipe


Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences
    (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

  • @BiocondaBot please update will cause the BiocondaBot to merge the master branch into a PR
  • @BiocondaBot please add label will add the please review & merge label.
  • @BiocondaBot please fetch artifacts will post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.

For members of the Bioconda project, the following command is also available:

  • @BiocondaBot please merge will cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.

If you have questions, please post them in gitter or ping @bioconda/core in a comment (if you are not able to directly ping @bioconda/core then the bot will repost your comment and enable pinging).

@Juke34
Copy link
Contributor Author

Juke34 commented Mar 27, 2020

@pvanheus you did work on the recipe in the past. Maybe you have recommendation for the recipe. Apparently you had set a $REPEATMASKER_LIB_DIR and $REPEATMASKER_LIB_DIR env variables. I have removed them, is it a problem?
Currently as it is in this recipe in order to add a new lib, the user has to put it directly in ${CONDA_PREFIX}/RepeatMasker/Libraries.

@jebrosen
Copy link
Contributor

Currently as it is in this recipe in order to add a new lib, the user has to put it directly in ${CONDA_PREFIX}/RepeatMasker/Libraries.

This changed significantly in 4.1.0 - RepeatMasker now respects the new -libdir flag or the LIBDIR environment variable at runtime to choose a different Libraries directory, which should be made from a copy of the Libraries directory that ships with RepeatMasker.

@Juke34
Copy link
Contributor Author

Juke34 commented Mar 27, 2020

OK then we can use LIBDIR to select a custom library at runtime, this is good. We should probably add a patch to the recipe to make this env more specific in order to avoid collapsing with a potential LIBDIR from another package. e.g replacing LIBDIR by REPEATMASKER_LIB_DIR

@abretaud
Copy link
Member

abretaud commented Sep 7, 2020

What's up here, can I help?
There's a 4.1.1 out now http://www.repeatmasker.org/

@nathanweeks
Copy link
Contributor

I would like to see this one completed as well. Note that 4.1.1 will need at least h5py and pandas. FWIW, the dependency trf has been updated to use the open source version, and I have an open PR to update rmblast.

@Juke34
Copy link
Contributor Author

Juke34 commented Sep 15, 2020

Sorry I have lost my fork of this work. I made a new PR here #24385 that take over this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants